From 36d0933d0da4c6998414f9ddf200c00e3c2088e5 Mon Sep 17 00:00:00 2001 From: Adi Dahiya Date: Wed, 22 Jan 2020 18:27:45 -0500 Subject: [PATCH] manual lint fixes --- packages/core/src/common/utils.ts | 4 +- packages/select/test/listItemsPropsTests.ts | 42 ++++++++++----------- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/packages/core/src/common/utils.ts b/packages/core/src/common/utils.ts index f391d23a25..532f399f95 100644 --- a/packages/core/src/common/utils.ts +++ b/packages/core/src/common/utils.ts @@ -209,8 +209,8 @@ export function countDecimalPlaces(num: number) { if (!isFinite(num)) { return 0; } - let e = 1, - p = 0; + let e = 1; + let p = 0; while (Math.round(num * e) / e !== num) { e *= 10; p++; diff --git a/packages/select/test/listItemsPropsTests.ts b/packages/select/test/listItemsPropsTests.ts index 10004332c8..7c21531f81 100644 --- a/packages/select/test/listItemsPropsTests.ts +++ b/packages/select/test/listItemsPropsTests.ts @@ -21,14 +21,14 @@ import { executeItemsEqual } from "../src/common/listItemsProps"; describe("IListItemsProps Utils", () => { describe("executeItemsEqual", () => { // interface for a non-primitive item value - interface ItemObject { + interface IItemObject { id: string; label: string; listOfValues: number[]; nullField: null; } - const ITEM_OBJECT_A: ItemObject = { + const ITEM_OBJECT_A: IItemObject = { id: "A", label: "Item A", listOfValues: [1, 2], @@ -36,21 +36,21 @@ describe("IListItemsProps Utils", () => { }; // Exactly the same contents as ITEM_OBJECT_A, but a different object - const ITEM_OBJECT_A_DUPLICATE: ItemObject = { + const ITEM_OBJECT_A_DUPLICATE: IItemObject = { id: "A", label: "Item A", listOfValues: [1, 2], nullField: null, }; - const ITEM_OBJECT_A_EQUIVALENT: ItemObject = { + const ITEM_OBJECT_A_EQUIVALENT: IItemObject = { id: "A", label: "Equivalent to item A based on 'id'", listOfValues: [3, 4], nullField: null, }; - const ITEM_OBJECT_B: ItemObject = { + const ITEM_OBJECT_B: IItemObject = { id: "B", label: "Item B", listOfValues: [5, 6], @@ -82,10 +82,10 @@ describe("IListItemsProps Utils", () => { describe("itemsEqual is a property name", () => { it("treats null and undefined as distinctly different", () => { - assert.isTrue(executeItemsEqual("id", null, null)); - assert.isTrue(executeItemsEqual("id", undefined, undefined)); - assert.isFalse(executeItemsEqual("id", null, undefined)); - assert.isFalse(executeItemsEqual("id", undefined, null)); + assert.isTrue(executeItemsEqual("id", null, null)); + assert.isTrue(executeItemsEqual("id", undefined, undefined)); + assert.isFalse(executeItemsEqual("id", null, undefined)); + assert.isFalse(executeItemsEqual("id", undefined, null)); }); it("compares primitives correctly", () => { @@ -101,13 +101,13 @@ describe("IListItemsProps Utils", () => { }); it("does not incorrectly compare null to a property with a null value", () => { - assert.isFalse(executeItemsEqual("nullField", ITEM_OBJECT_A, null)); + assert.isFalse(executeItemsEqual("nullField", ITEM_OBJECT_A, null)); }); }); describe("itemsEqual is a function", () => { // Simple equality comparator that compares IDs of ItemObjects. - const equalityComparator = sinon.spy((itemA: ItemObject, itemB: ItemObject): boolean => { + const equalityComparator = sinon.spy((itemA: IItemObject, itemB: IItemObject): boolean => { return itemA.id === itemB.id; }); @@ -116,33 +116,33 @@ describe("IListItemsProps Utils", () => { }); it("treats null and undefined as distinctly different", () => { - assert.isTrue(executeItemsEqual(equalityComparator, null, null)); - assert.isTrue(executeItemsEqual(equalityComparator, undefined, undefined)); - assert.isFalse(executeItemsEqual(equalityComparator, null, undefined)); - assert.isFalse(executeItemsEqual(equalityComparator, undefined, null)); + assert.isTrue(executeItemsEqual(equalityComparator, null, null)); + assert.isTrue(executeItemsEqual(equalityComparator, undefined, undefined)); + assert.isFalse(executeItemsEqual(equalityComparator, null, undefined)); + assert.isFalse(executeItemsEqual(equalityComparator, undefined, null)); assert(!equalityComparator.called); }); it("calls the function and uses its result (true)", () => { assert.isTrue( - executeItemsEqual(equalityComparator, ITEM_OBJECT_A, ITEM_OBJECT_A_EQUIVALENT), + executeItemsEqual(equalityComparator, ITEM_OBJECT_A, ITEM_OBJECT_A_EQUIVALENT), ); assert(equalityComparator.calledWith(ITEM_OBJECT_A, ITEM_OBJECT_A_EQUIVALENT)); assert(equalityComparator.returned(true)); }); it("calls the function and uses its result (false)", () => { - assert.isFalse(executeItemsEqual(equalityComparator, ITEM_OBJECT_A, ITEM_OBJECT_B)); + assert.isFalse(executeItemsEqual(equalityComparator, ITEM_OBJECT_A, ITEM_OBJECT_B)); assert(equalityComparator.calledWith(ITEM_OBJECT_A, ITEM_OBJECT_B)); assert(equalityComparator.returned(false)); }); it("does not call the function if one param is null/undefined", () => { - assert.isFalse(executeItemsEqual(equalityComparator, ITEM_OBJECT_A, null)); - assert.isFalse(executeItemsEqual(equalityComparator, ITEM_OBJECT_A, undefined)); - assert.isFalse(executeItemsEqual(equalityComparator, null, ITEM_OBJECT_A)); - assert.isFalse(executeItemsEqual(equalityComparator, undefined, ITEM_OBJECT_A)); + assert.isFalse(executeItemsEqual(equalityComparator, ITEM_OBJECT_A, null)); + assert.isFalse(executeItemsEqual(equalityComparator, ITEM_OBJECT_A, undefined)); + assert.isFalse(executeItemsEqual(equalityComparator, null, ITEM_OBJECT_A)); + assert.isFalse(executeItemsEqual(equalityComparator, undefined, ITEM_OBJECT_A)); assert(!equalityComparator.called); });