Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary dependency on protocol-buffers #1

Closed
pakoito opened this issue Oct 4, 2016 · 3 comments
Closed

Unnecessary dependency on protocol-buffers #1

pakoito opened this issue Oct 4, 2016 · 3 comments
Assignees
Labels

Comments

@pakoito
Copy link
Owner

pakoito commented Oct 4, 2016

Reported by /u/Magillus:

Problem: method count padded by 6k by protocol buffers
http://www.methodscount.com/?lib=com.github.pakoito%3ARxObservableDiskCache%3A1.0.0

Solutions:
It just doesn't work as expected so I've open an issue in their repo magro/kryo-serializers#59.

Alternatively, I've created a PR for PaperDb pilgr/Paper#54 to use a fork of the serialisers while the problem is being solved.

@pakoito
Copy link
Owner Author

pakoito commented Oct 6, 2016

Update:

Kryo-serializers has updated to remove the unnecessary dependency. If you're in a hurry, add version 0.39 explicitly to your build.gradle: https://github.com/magro/kryo-serializers/releases/tag/kryo-serializers-0.39

For everyone else, there has been a major update for kryo 4.0 and and kyro-serializers has updated to it, so https://github.com/magro/kryo-serializers/releases/tag/kryo-serializers-0.40 is available now. PaperDb is also updating to this version, and is currently in RC status: https://github.com/pilgr/Paper/releases/tag/2.0-rc1

As soon as PaperDb updates I'll update RxPaper too.

@pakoito
Copy link
Owner Author

pakoito commented Oct 29, 2016

Update:

Paper 2.0 has officially released

https://github.com/pilgr/Paper/releases/tag/2.0

When:

Hopefully I will be able to tackle this by next weekend. If I haven't in more than 2 weeks and you're reading this, please @ remind me.

@pakoito
Copy link
Owner Author

pakoito commented Nov 3, 2016

@pakoito pakoito closed this as completed Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant