-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy trust store to /tmp to work with readonly fs #288
Copy trust store to /tmp to work with readonly fs #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One very minor thing and one question.
Co-authored-by: Sumit Kulhadia <sumit.kulhadia@sap.com>
7152a1d
to
e6fb742
Compare
We added the usage of |
@dmikusa is there a release planned for libjvm? |
I was kind of hoping to get #158 sorted before cutting a release, but if this one is urgent for you we can move ahead without doing that. |
Hi @dmikusa can you release paketo-buildpacks/adoptium with this new version of libjvm? I am using adoptium buildpack and it is not using the latest released version of this libjvm library. Cheers, Jagrut |
We're bumping libpak first, so we can get in a fix there too. The libjvm release should be out shortly. Then we can bump the buildpacks. 🤞 it'll be in this Friday's release. |
@tojagrut I just cut releases for all of our JVM provider buildpacks. If you're using one directly you can get that now. Otherwise, we'll bump the composite to include this fix on Friday as part of the normal release cycle. @loewenstein SAP Machine buildpack is released & includes this fix, and also the other @c0d1ngm0nk3y patched around dependency comparison. |
@beytularedzheb Please open a new issue, and we can discuss it. Include some details about your use case and why you are setting that flag. Thanks |
fixes #281
Summary
In case the truststore is readonly (readonly filesystem), it is copied to
/tmp
and used from there. That allows loadingcacerts
even with a readonly filesystem.If
/tmp
is also readonly, it will still not fail, but warn the user about this. This is the previous behaviour.Use Cases
Container is started with a readonly filesystem for security reasons.
Checklist