feat(plugins): added checks results in interface passed to plugins

padok-team · Sep 26, 2022 · 894ab98 · 894ab98
1 parent e9678c2
commit 894ab98
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 133 deletions.
diff --git a/internal/cli/cli.go b/internal/cli/cli.go
@@ -31,7 +31,7 @@ func initialisePlugins(configuration commons.Config) error {
 	return nil
 }
 
-func RunChecksPlugins(configuration *commons.Config, checks *[]commons.Tests) {
+func runChecksPlugins(configuration *commons.Config, checks *[]commons.Tests) {
 	for _, plugins := range configuration.Plugins {
 		if plugins.Type == "checks" || plugins.Type == "" {
 
@@ -92,7 +92,7 @@ func runModPlugins(configuration *commons.Config, checks *[]commons.Tests) bool
 	return mod
 }
 
-func RunReportPlugins(configuration *commons.Config, checks *[]commons.Tests) {
+func runReportPlugins(configuration *commons.Config, checks *[]commons.Tests) {
 	for _, plugins := range configuration.Plugins {
 		if plugins.Type == "report" {
 			latestVersion, _ := commons.GetLatestReleaseTag(plugins)
@@ -127,7 +127,7 @@ func Execute() error {
 	}
 
 	// Run plugins
-	RunChecksPlugins(configuration, &checks)
+	runChecksPlugins(configuration, &checks)
 
 	// Clean results
 	checks = report.RemoveIgnored(configuration, checks)
@@ -142,14 +142,16 @@ func Execute() error {
 		})
 	}
 
+	configuration.Tests = checks
+
 	// Compare with previous report
 	compareResults(configuration, &checks)
 
 	// CI reporting
 	ciReporting(checks)
 
 	// Run report plugins
-	RunReportPlugins(configuration, &checks)
+	runReportPlugins(configuration, &configuration.Tests)
 
 	return nil
 }
diff --git a/plugins/commons/config.go b/plugins/commons/config.go
@@ -12,6 +12,7 @@ type Config struct {
 	AWS          []AWS_Account            `yaml:"aws"`
 	Ignore       []Ignore                 `yaml:"ignore"`
 	PluginConfig []map[string]interface{} `yaml:"pluginsConfiguration"`
+	Tests        []Tests                  `yaml:"tests"`
 }
 
 func ParseConfig(configFile string) (*Config, error) {

diff --git a/plugins/custom/custom.go b/plugins/custom/custom.go
diff --git a/plugins/custom/custom_test.go b/plugins/custom/custom_test.go
diff --git a/plugins/manager/manager.go b/plugins/manager/manager.go
@@ -63,7 +63,7 @@ func RunPlugin(pluginInput commons.Plugin, c *commons.Config) []commons.Tests {
 // This prevents users from executing bad plugins or executing a plugin
 // directory. It is a UX feature, not a security feature.
 var handshakeConfig = plugin.HandshakeConfig{
-	ProtocolVersion:  2,
+	ProtocolVersion:  3,
 	MagicCookieKey:   "BASIC_PLUGIN",
 	MagicCookieValue: "hello",
 }