Skip to content

Commit 678b292

Browse files
committed
test: Update ODBC driver version to 18 in remaining places
1 parent 2ad3b3d commit 678b292

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

Contributing.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ This starts two containers called `odbc2parquet_dev` and `odbc2parquet_mssql`. Y
2525
Otherwise you can manually install these requirements from here:
2626

2727
* Install Rust compiler and Cargo. Follow the instructions on [this site](https://www.rust-lang.org/en-US/install.html).
28-
* [Microsoft ODBC Driver 17 for SQL Server](https://docs.microsoft.com/en-us/sql/connect/odbc/download-odbc-driver-for-sql-server?view=sql-server-ver15).
28+
* [Microsoft ODBC Driver 18 for SQL Server](https://docs.microsoft.com/en-us/sql/connect/odbc/download-odbc-driver-for-sql-server?view=sql-server-ver15).
2929
* An ODBC Driver manager if you are not on windows: http://www.unixodbc.org/
3030
* The command line tools shipping with the `parquet` crate are invoked by the tests. `cargo install parquet --features cli`.
3131

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ Use `odbc2parquet help query` to see all options related to fetching data.
126126

127127
```bash
128128
odbc2parquet query \
129-
--connection-string "Driver={ODBC Driver 17 for SQL Server};Server=localhost;UID=SA;PWD=<YourStrong@Passw0rd>;" \
129+
--connection-string "Driver={ODBC Driver 18` for SQL Server};Server=localhost;UID=SA;PWD=<YourStrong@Passw0rd>;TrustServerCertificate=yes;" \
130130
out.par \
131131
"SELECT * FROM Birthdays"
132132
```
@@ -146,7 +146,7 @@ out.par1 \
146146
147147
```shell
148148
odbc2parquet query \
149-
--connection-string "Driver={ODBC Driver 17 for SQL Server};Server=localhost;UID=SA;PWD=<YourStrong@Passw0rd>;" \
149+
--connection-string "Driver={ODBC Driver 18 for SQL Server};Server=localhost;UID=SA;PWD=<YourStrong@Passw0rd>;TrustServerCertificate=yes;" \
150150
out.par \
151151
"SELECT * FROM Birthdays WHERE year > ? and year < ?" \
152152
1990 2010
@@ -168,7 +168,7 @@ odbc2parquet list-data-sources
168168
169169
```shell
170170
odbc2parquet insert \
171-
--connection-string "Driver={ODBC Driver 17 for SQL Server};Server=localhost;UID=SA;PWD=<YourStrong@Passw0rd>;" \
171+
--connection-string "Driver={ODBC Driver 18 for SQL Server};Server=localhost;UID=SA;PWD=<YourStrong@Passw0rd>;TrustServerCertificate=yes;" \
172172
input.par \
173173
MyTable
174174
```

tests/integration.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ fn append_user_and_password_to_connection_string() {
7979
TableMssql::new(table_name, &["VARCHAR(10)"]);
8080

8181
// Connection string without user name and password.
82-
let connection_string = "Driver={ODBC Driver 17 for SQL Server};Server=localhost;";
82+
let connection_string = "Driver={ODBC Driver 18 for SQL Server};Server=localhost;\
83+
TrustServerCertificate=yes;";
8384
// A temporary directory, to be removed at the end of the test.
8485
let out_dir = tempdir().unwrap();
8586
// The name of the output parquet file we are going to write. Since it is in a temporary

0 commit comments

Comments
 (0)