fix: 当packing.commonChunks为空时，不应该输出manifest.js

packingjs · Jan 29, 2018 · 6c20f4c · 6c20f4c
1 parent 1fd5a42
commit 6c20f4c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/config/webpack.build.babel.js b/src/config/webpack.build.babel.js
@@ -168,7 +168,7 @@ const webpackConfig = () => {
   // 从配置文件中获取并生成webpack打包配置
   // fix: #14
   let chunkNames = [];
-  if (commonChunks) {
+  if (commonChunks && Object.keys(commonChunks).length > 0) {
     const manifestChunkName = 'manifest';
     chunkNames = Object.keys(commonChunks);
     const lastChunkName = chunkNames[chunkNames.length - 1];

diff --git a/src/config/webpack.serve.babel.js b/src/config/webpack.serve.babel.js
@@ -12,7 +12,6 @@ import OpenBrowserPlugin from 'open-browser-webpack-plugin';
 import ProfilesPlugin from 'packing-profile-webpack-plugin';
 import pRequire from '../util/require';
 
-const packing = pRequire('config/packing');
 const { cdnRoot } = pRequire(`src/profiles/${process.env.NODE_ENV}`);
 const {
   assetExtensions,
@@ -21,6 +20,7 @@ const {
   hot,
   cssModules,
   cssModulesIdentName = '[path][name]__[local]--[hash:base64:5]',
+  commonChunks,
   path: {
     src,
     assets,
@@ -155,8 +155,8 @@ const webpackConfig = (program) => {
   }));
 
   // 从配置文件中获取dll
-  if (packing.commonChunks) {
-    Object.keys(packing.commonChunks).forEach((key) => {
+  if (commonChunks && Object.keys(commonChunks).length > 0) {
+    Object.keys(commonChunks).forEach((key) => {
       plugins.push(new webpack.DllReferencePlugin({
         context,
         // eslint-disable-next-line