Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine uses passphrasesOut instead of In to open existing keystores #44

Closed
schonex opened this issue Sep 3, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@schonex
Copy link
Contributor

schonex commented Sep 3, 2023

Describe the bug
combine helper command uses the passphrasesOut instead of passphrasesIn to open the sharded (distributed) keystores.

Expected behavior
I believe these two commands should be called with cr.passphrasesIn

https://github.com/p2p-org/dkc/blob/main/cmd/combine/helpers.go#L175
https://github.com/p2p-org/dkc/blob/main/cmd/combine/helpers.go#L181

@schonex schonex added the bug Something isn't working label Sep 3, 2023
@SpontaneousOverthrow
Copy link
Contributor

fixed here #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants