Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image upload e2e flakes in safari #2442

Closed
david-crespo opened this issue Sep 13, 2024 · 0 comments · Fixed by #2444
Closed

Fix image upload e2e flakes in safari #2442

david-crespo opened this issue Sep 13, 2024 · 0 comments · Fixed by #2444
Milestone
11

Comments

@david-crespo
Copy link
Collaborator

#2440 made it worse, so in 53e1da7 I skipped the image upload cancel test in Safari. Bizarrely, that seemed to enable a different set of image upload-related tests to fail in Safari. Since the ratio of signal to noise here is ZERO I think we might want to skip all these tests in Safari.
@david-crespo david-crespo added this to the 11 milestone Sep 13, 2024
@david-crespo david-crespo linked a pull request Sep 13, 2024 that will close this issue
chore: skip image upload e2es in safari #2444
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11
Development

Successfully merging a pull request may close this issue.

chore: skip image upload e2es in safari oxidecomputer/console
1 participant
@david-crespo