Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically resume unfinished uploads after site-reload #7837

Open
JammingBen opened this issue Oct 21, 2022 · 1 comment
Open

Automatically resume unfinished uploads after site-reload #7837

JammingBen opened this issue Oct 21, 2022 · 1 comment
Labels
Category:Enhancement Add new functionality

Comments

@JammingBen
Copy link
Contributor

Currently, we are able to pause and resume uploads. In the future we also want to possibility to resume cancelled/unfinished uploads (e.g. when cancelling an upload directly, or cancelling it via a page reload).

Tus & Uppy already bring the prerequisites for this feature, as each upload will be stored in the local storage. Currently, those entries will be removed on cancel though (might be related to the removeFingerprintOnSuccess option). Hence we need to make sure those entries stay present on cancel so they can be resumed later.

@JammingBen JammingBen added the Category:Enhancement Add new functionality label Oct 21, 2022
@JammingBen
Copy link
Contributor Author

I digged into this a bit.

With #8055, it is possible to resume a cancelled upload, even after a site reload. But the user needs to manually upload the file again. Thanks to tus, the upload will then continue were it left off.

For automatically resuming uploads, Uppy provides a plugin called Golden Retriever. I tried it, unfortunately it didn't work out of the box when trying with a folder including ~150 files. It's recommended to use a service worker for this, which I didn't. Maybe that would improve things. Or maybe our custom tus plugin and/or the logic for folder uploads causes issues here.

@JammingBen JammingBen changed the title Make cancelled/unfinished uploads resumable Automatically resume unfinished uploads after site-reload Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
None yet
Development

No branches or pull requests

1 participant