Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context menu & roles: Text-alignment is wrong #7619

Closed
tbsbdr opened this issue Sep 9, 2022 · 4 comments · Fixed by owncloud/owncloud-design-system#2323
Closed

Context menu & roles: Text-alignment is wrong #7619

tbsbdr opened this issue Sep 9, 2022 · 4 comments · Fixed by owncloud/owncloud-design-system#2323
Assignees
@JammingBen
Labels
Priority:p4-low Low priority Type:Bug Something isn't working

Comments

@tbsbdr
Copy link

tbsbdr commented Sep 9, 2022

Steps to reproduce

  • visible only if the text gets to long, ex. in german

Screenshot 000496@2x

Expected behaviour

text should be left aligned
@tbsbdr tbsbdr added the Type:Bug Something isn't working label Sep 9, 2022
@tbsbdr tbsbdr changed the title Permissions: Text-alignment is wrong Context menu: Text-alignment is wrong Sep 9, 2022
@tbsbdr tbsbdr added the Priority:p2-high Escalation, on top of current planning, release blocker label Sep 9, 2022
@JammingBen JammingBen self-assigned this Sep 12, 2022
@JammingBen
Copy link
Contributor

@tbsbdr I can't reproduce this, is it still happening for you? If so, which browser do you use?

image

@tbsbdr
Copy link
Author

tbsbdr commented Sep 12, 2022

can't reproduce the screenshot neither.

though it might still exist for verbose translations as text is set to text-alginment:center

setting it to p4 as I can't provoke a userfacing issue - exists just in theory:

@tbsbdr tbsbdr added Priority:p4-low Low priority and removed Priority:p2-high Escalation, on top of current planning, release blocker labels Sep 12, 2022
@tbsbdr
Copy link
Author

tbsbdr commented Sep 12, 2022

As discussed, this might be related.

  • short text in permissions is left aligned -> OK ✅
  • long text in permissions gets centered -> Not OK ❌

@tbsbdr tbsbdr changed the title Context menu: Text-alignment is wrong Context menu & roles: Text-alignment is wrong Sep 12, 2022
@JammingBen JammingBen mentioned this issue Sep 13, 2022
Merged
5 tasks
@JammingBen
Copy link
Contributor

Has been fixed with owncloud/owncloud-design-system#2323, will ship with the next ODS update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JammingBen JammingBen

Labels
Priority:p4-low Low priority Type:Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change button text alignment to left owncloud/owncloud-design-system
2 participants
@tbsbdr @JammingBen