Updater should be in Admin settings rather than separate window #40
Comments
|
@jancborchardt Just for fun I tried to shift the view into admin-panel today. I can create a new branch for working on/finishing this (I have it local at the moment). Is that the way to go?
I think we should add a short sentence of explanation here. Something like: Here you can find backups of the core of your ownCloud (excluding your data) after you did an update to a newer version. Please backup your data separately before updating! And: We can add the size of every backup to the list, because it makes immediately clear that my 876 gigabytes data can't be backuped in a 40 megabytes zip-file.
Question is, if this is still a topic, since it works with Angular (though there might be better soultions – I'm no expert for usage of frameworks)
|
Details: Move the interface from the separate template into the admin-template. Remove the link to the separate page. Remove the separate page and the route. Adjust the CSS to make the updater fit better into the admin-page. Remove some pixel-values and replace with relative values. Add a column to the backups table where the size of each backup is shown as first step of making clearer what "backups" means (see owncloud#39)
|
@te-online wow! I’m seriously impressed :) Such a cool contribution! Do you have a branch for that already in here? @VicDeo @DeepDiver1975 what do you think? |
|
@jancborchardt Thanks! :) Branch is pushed now. Nevertheless, there are some points on the todo:
@VicDeo @DeepDiver1975 Are there even points to add? I will finish that soon, but I would like to hear some opinions on which decisions should be made. I had some thoughts on the backups: Maybe it's worth an idea to drop the backups into some folder in the admin's owncloud (user specified). That would add the advantage to have trash and versioning dealing with always-same-name-backup-zips (adding the problem that you couldn't say which backup contains which oc version, and that you trashed all backups at once if you did). Maybe that's too fancy at all :D On the long run, I like the idea of adding a backup-app to ownCloud that manages such stuff. For now, I think we should make the current approach as usable and understanable as possible. Have a nice weekend! :-) |
|
@te-online any updates so far? @VicDeo @DeepDiver1975 it would be really important to get your input here. |
|
@jancborchardt Not yet, but it's on my list. ;-) I think I can check the points mentioned above until end of the week. |
Details: Adds a note about what updater-backups are. Adds a temporary styling for the notification. Adds a native confirmation dialogue when deleting such backups. Fixes a typo.
|
Tested it now with 7.0.3 to 7.0.4. Update works as expected in admin menu. Another problem is, that I don't know how to style the note for the backups, because there doesn't seem to be any predefined class for the admin-panel to structure things a bit. |
|
What's next here? In my opinion the text and style can be kept like that for now – but that's giving feedback on my own work. There is obviously some space for improvements. (see screenshot)
I'd like to do a pull request from the branch move-to-master as it is. That would mean someone has to manually check, what changed since then, I guess, because the code moved to another file due to the fact that the app was moved to admin. As you see, I'm a bit confused about that, maybe some git-expert may help, so that we can finish this ;-) |
|
Done #82 |
|
@VicDeo @te-online oh btw – does an the »Updater« entry show in the sidebar as well? Maybe @DeepDiver1975 needs to help to put that in. |
|
@jancborchardt it's automatic |
|
I thought about what you mentioned here, @VicDeo #86 (comment).
Would it be possible to provide an external page (like we removed with this) that only holds the backups? I mean would this page be accessible if the ownCloud inteface can't be loaded? The link to this page could be provided in the message after a crash happened while updating. |
|
@te-online this is potentially unsafe |
|
I mean the same way we did it before? So this was also more potentially unsafe than keeping it to the admin-page? I'm unsure whether this page can be independent while it depends on the login session of the user. But maybe it's just a trash-idea... |
|
@te-online how are you going to prove that user seeing this page is admin when OC is broken? |
|
@VicDeo That's my question 😄. Okay I see, this is not possible. So when OC is broken using the separate update/backups page, this page wasn't accessible either, because login couldn't be confirmed? (I'm only speaking of the current browser-session). A light version of this approach would be to add a hint to the crash-message that backups exist and can be downloaded via ftp/whatever. |
As already discussed in the past in owncloud/core#5279 and owncloud-archive/apps#1640
I hope after we merge the style fixes #39 we can look into moving the whole thing directly into admin settings. And making the »Backup« part less confusing.
cc @VicDeo @DeepDiver1975
The text was updated successfully, but these errors were encountered: