From be4a6b761f16f011ebc0d9a414fba6e9ac77125a Mon Sep 17 00:00:00 2001 From: Benedikt Kulmann Date: Tue, 1 Feb 2022 12:44:13 +0100 Subject: [PATCH 1/2] Reject promise when network request fails in OCS --- changelog/1.1.2_2022-02-01/bugfix-ocs-reject | 5 +++++ src/helperFunctions.js | 3 +++ 2 files changed, 8 insertions(+) create mode 100644 changelog/1.1.2_2022-02-01/bugfix-ocs-reject diff --git a/changelog/1.1.2_2022-02-01/bugfix-ocs-reject b/changelog/1.1.2_2022-02-01/bugfix-ocs-reject new file mode 100644 index 000000000..a8e274659 --- /dev/null +++ b/changelog/1.1.2_2022-02-01/bugfix-ocs-reject @@ -0,0 +1,5 @@ +Bugfix: Graceful reject for failing network request in OCS + +When the network request inside a _makeOCSrequest failed it terminated the entire application instead of rejecting the promise. We now catch errors on the network request and reject the promise so that applications have a chance to handle the error. + +https://github.com/owncloud/owncloud-sdk/pull/977 diff --git a/src/helperFunctions.js b/src/helperFunctions.js index 579e78ddd..cd879f8f2 100644 --- a/src/helperFunctions.js +++ b/src/helperFunctions.js @@ -301,6 +301,9 @@ class helpers { data: tree }) }) + .catch(e => { + return reject(e) + }) }) } From 3fdc700278225cfb2f72b3611f033b21659e49be Mon Sep 17 00:00:00 2001 From: Benedikt Kulmann Date: Tue, 1 Feb 2022 12:46:31 +0100 Subject: [PATCH 2/2] Bump version to 1.1.2 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 857a688fa..2ae0bf4b8 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "owncloud-sdk", - "version": "1.1.1", + "version": "1.1.2", "description": "ownCloud client library for JavaScript", "keywords": [ "owncloud",