Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Use OcSpinner as loading spinner in OcSelect #1351

Closed
dschmidt opened this issue Jun 3, 2021 · 1 comment
Closed

Use OcSpinner as loading spinner in OcSelect #1351

dschmidt opened this issue Jun 3, 2021 · 1 comment

Comments

@dschmidt
Copy link
Member

dschmidt commented Jun 3, 2021

I'm not sure this is desirable after all, but I just had the idea and played around with it and would like to put it up for discussion:

vue-select has a slot for customizing the loading animation, maybe it would be cool to use our own spinner there by default instead of the vue-select one ... we have one already and it we could possibly unify the look even more 🤷🏻

The documentation is a little sparse (https://vue-select.org/guide/ajax.html#loading-spinner) but I could make it work like this:

<template v-slot:spinner="{ loading }">
  <oc-spinner v-show="loading" aria-label="Loading" size="medium"/>
</template>

The only issue is that the animation is wobbling. My CSS foo is not strong, but I assume it should be rather easy to fix :)

@dschmidt
Copy link
Member Author

dschmidt commented Sep 5, 2021

Fixed in #1521

@dschmidt dschmidt closed this as completed Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant