Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiAntivirus/antivirus.feature:279 is flaky #7219

Closed
butonic opened this issue Sep 5, 2023 · 3 comments
Closed

apiAntivirus/antivirus.feature:279 is flaky #7219

butonic opened this issue Sep 5, 2023 · 3 comments

Comments

@butonic
Copy link
Member

butonic commented Sep 5, 2023

in https://drone.owncloud.com/owncloud/ocis/26185/61/8 the apiAntivirus/antivirus.feature:279 failed:

  @env-config @issue-6494
  Scenario Outline: upload a file with virus by setting antivirus infected file handling config to continue                # /drone/src/tests/acceptance/features/apiAntivirus/antivirus.feature:270
    Given the config "ANTIVIRUS_INFECTED_FILE_HANDLING" has been set to "continue"                                         # OcisConfigContext::theConfigHasBeenSetTo()
    And using <dav-path-version> DAV path                                                                                  # FeatureContext::usingOldOrNewDavPath()
    When user "Alice" uploads file "filesForUpload/filesWithVirus/eicar.com" to "/aFileWithVirus.txt" using the WebDAV API # FeatureContext::userUploadsAFileTo()
    Then the HTTP status code should be "201"                                                                              # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And as "Alice" file "/aFileWithVirus.txt" should exist                                                                 # FeatureContext::asFileOrFolderShouldExist()

    Examples:
      | dav-path-version |
      | old              |
      | new              |
        Failed step: Then the HTTP status code should be "201"
        HTTP status code 404 is not the expected value 201
        Failed asserting that 404 matches expected '201'.
      | spaces           |

but the only code change was:

diff --git a/services/proxy/pkg/command/server.go b/services/proxy/pkg/command/server.go
index 3a5f0c8eaa1..c7b9fe3b623 100644
--- a/services/proxy/pkg/command/server.go
+++ b/services/proxy/pkg/command/server.go
@@ -367,6 +367,7 @@ func loadMiddlewares(ctx context.Context, logger log.Logger, cfg *config.Config,
 			oidc.WithOidcIssuer(cfg.OIDC.Issuer),
 			oidc.WithJWKSOptions(cfg.OIDC.JWKS),
 		)),
+		middleware.SkipUserInfo(cfg.OIDC.SkipUserInfo),
 	))
 	authenticators = append(authenticators, middleware.SignedURLAuthenticator{
 		Logger:             logger,

AFAICT unrelated to older issues in #3921

@SwikritiT
Copy link
Contributor

SwikritiT commented Sep 6, 2023

similar failure here:https://drone.owncloud.com/owncloud/ocis/26268/62/8
The scenario is different but the test is failing similarly

  @env-config
  Scenario Outline: upload a file with virus larger than the upload threshold                                                  # /drone/src/tests/acceptance/features/apiAntivirus/antivirus.feature:299
    Given the config "ANTIVIRUS_MAX_SCAN_SIZE" has been set to "100"                                                           # OcisConfigContext::theConfigHasBeenSetTo()
    And using <dav-path-version> DAV path                                                                                      # FeatureContext::usingOldOrNewDavPath()
    When user "Alice" uploads file "filesForUpload/filesWithVirus/eicar_com.zip" to "/aFileWithVirus.txt" using the WebDAV API # FeatureContext::userUploadsAFileTo()
    Then the HTTP status code should be "201"                                                                                  # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And as "Alice" file "/aFileWithVirus.txt" should exist                                                                     # FeatureContext::asFileOrFolderShouldExist()

    Examples:
      | dav-path-version |
      | old              |
      | new              |
      | spaces           |
        Failed step: Then the HTTP status code should be "201"
        HTTP status code 404 is not the expected value 201
        Failed asserting that 404 matches expected '201'.

@SwikritiT SwikritiT added the Priority:p2-high Escalation, on top of current planning, release blocker label Sep 6, 2023
@SagarGi SagarGi added QA:p2 and removed Priority:p2-high Escalation, on top of current planning, release blocker labels Sep 7, 2023
@SagarGi SagarGi self-assigned this Sep 7, 2023
@SagarGi
Copy link
Member

SagarGi commented Sep 12, 2023

Cannot reproduce it locally and is not seen in recent builds. Can be put on hold for some more time if failed again then can be looked into deep.

@SagarGi SagarGi removed their assignment Sep 12, 2023
@saw-jan
Copy link
Member

saw-jan commented Sep 22, 2023

issue with file upload. Same as #7337, will continue further invetigation there

@saw-jan saw-jan closed this as completed Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants