Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space admin should not not be able to change the user quota #5475

Closed
ScharfViktor opened this issue Jan 30, 2023 · 4 comments
Closed

Space admin should not not be able to change the user quota #5475

ScharfViktor opened this issue Jan 30, 2023 · 4 comments
Assignees
Labels

Comments

@ScharfViktor
Copy link
Contributor

Steps:

  • Katherine tries to change Albert Einstein quota

curl -k -X PATCH 'https://localhost:9200/graph/v1.0/drives/EinsteinPersonalSpaceId' -ukatherine:gemini -d '{"quota": {"total": 0}}' -vk

Actual: user and group tab is hidden for Space admin user in administation setting
but he can change the users personal space quota via the api

Expect: 401. no permission to change quota

@kobergj
Copy link
Collaborator

kobergj commented Feb 24, 2023

Interesting finding. This is because the server doesn't differentiate between personal and project spaces when updating. That means Katherine, who is space manager, actually HAS the permission to edit the quota of all spaces.

If this is not the intended behavior we have two options:
A) Split set-space-quota permission to set-project-space-quota and set-personal-space-quota
B) Check for account-management (or some other) permissions when trying to update personal spaces

@micbar what do you think?

@micbar
Copy link
Contributor

micbar commented Feb 25, 2023

I think we should go with solution A9

@kobergj
Copy link
Collaborator

kobergj commented Feb 27, 2023

Needs a web update first otherwise changing of quota is no longer possible through the UI. See ocis PR #5662

@kobergj
Copy link
Collaborator

kobergj commented Mar 20, 2023

Fixed with #5843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants