Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt-all should not touch already encrypted files #52

Closed
PVince81 opened this issue Sep 6, 2018 · 3 comments
Closed

Encrypt-all should not touch already encrypted files #52

PVince81 opened this issue Sep 6, 2018 · 3 comments
Assignees

Comments

@PVince81
Copy link
Contributor

PVince81 commented Sep 6, 2018

Steps

  1. Setup master key encryption
  2. Run occ encryption:encrypt-all
  3. Create a user "user1"
  4. Login as that user
  5. Upload some files
  6. Log out
  7. Decrypt the user's files occ encryption:decrypt-all user1
  8. Change your mind and reencrypt: occ encryption:encrypt-all

Expected

A user argument for "encrypt-all" would be nice.
The second encryption pass only encrypts the files of user1 since the admin's files are already encrypted.

Actual

The process attempts to reencrypt already encrypted files from admin and fails:

Start to encrypt users files
----------------------------



 encrypt files for user admin (1): /admin/files/ownCloud Manual.pdf 
 [->--------------------------]
In Crypt.php line 483:
                 
  Bad Signature  
                 

encryption:encrypt-all

at this stage, none of the files of user1 are encrypted. I'd need to first decrypt everything then encrypt again.

Version

ownCloud 10.0.10 RC1

@sharidas
Copy link
Contributor

Estimate: 1.5 md

@PVince81
Copy link
Contributor Author

this is only about skipping already encrypted files

@sharidas
Copy link
Contributor

sharidas commented Oct 16, 2018

master branch pr -> #61
stable10 branch pr -> owncloud/core#33206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants