Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the replaceUsernames setting in .drone.star #3091

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

phil-davis
Copy link
Contributor

This documents the replaceUsernames setting that can by used by developers or QA to run acceptance tests with different user names and user attributes.

Part of issue owncloud/core#33596

PR owncloud/core#38364 adds this CI functionality. This docs PR can be merged when that core PR is merged.

No backport - this is new CI functionality in core master.

@phil-davis
Copy link
Contributor Author

The related PR has been merged. This PR is ready for review.

@mmattel
Copy link
Contributor

mmattel commented Feb 1, 2021

Q: in the example, the content starts at the first line with a tab. Wouldnt it be good to reduce the indent of all lines by one tab making the result not so wide? Or is there an intention behind?

@phil-davis
Copy link
Contributor Author

Q: in the example, the content starts at the first line with a tab. Wouldnt it be good to reduce the indent of all lines by one tab making the result not so wide? Or is there an intention behind?

I will adjust it. I did copy-paste of the example from .drone.star and that block was indented a lot.

@phil-davis phil-davis force-pushed the replaceUsernames-drone-star-setting branch from 5bfafab to 707dc5a Compare February 1, 2021 14:39
@mmattel
Copy link
Contributor

mmattel commented Feb 1, 2021

Just re-reading the text and one thing pops up, maybe I do not fully understanding it, but
Commit the changes to .drone.star and tests/acceptance/usernames.json, push to GitHub, and make a PR:
reads to my as an invite that everyone can now make a PR on GH overwriting the existing setup for a replaced username setting. Is this intended?
The settings below in the bash part may be fully correct, but there is no statement in which reference it stands for the text above.

@phil-davis
Copy link
Contributor Author

reads to my as an invite that everyone can now make a PR on GH overwriting the existing setup for a replaced username setting. Is this intended?

I had better write more words! This is for running a test to see if some weird combinations username, display name, email address... break anything. The PR just makes CI run to get a result. It is not intended to be merged. Someone could try to run the whole test suite locally on their machine at home, but it would take all day. With a "demonstration" PR they can test some combination that might be suspected of having a problem.

The challenge is how to write useful words, but not write a whole essay like in the paragraph above.

@phil-davis phil-davis force-pushed the replaceUsernames-drone-star-setting branch from 707dc5a to 435dd95 Compare February 1, 2021 16:34
@phil-davis
Copy link
Contributor Author

I wrote more words - @mmattel comments?

@phil-davis phil-davis force-pushed the replaceUsernames-drone-star-setting branch 2 times, most recently from fea1143 to f37040f Compare February 1, 2021 16:46
@phil-davis phil-davis force-pushed the replaceUsernames-drone-star-setting branch from f37040f to 7c26f88 Compare February 1, 2021 16:54
@phil-davis phil-davis requested a review from mmattel February 1, 2021 16:54
@phil-davis phil-davis merged commit abea446 into master Feb 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the replaceUsernames-drone-star-setting branch February 1, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants