Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User password cannot be "0" #115

Closed
wants to merge 2 commits into from
Closed

User password cannot be "0" #115

wants to merge 2 commits into from

Conversation

voroyam
Copy link
Contributor

@voroyam voroyam commented Sep 24, 2018

In the upcoming 10.0.10 a user password cannot be set to "0".

@mmattel
Copy link
Contributor

mmattel commented Sep 24, 2018

@voroyam FYI
I have created #113 (more occ fixes) which contains many improvements on both occ command files, inlcuding the pwd cant be zero text.

Please revert in this PR your changes of occ_command.adoc, so #113 can be merged without conflict.
Your changes in user_configuration.adoc are totally fine !

@voroyam
Copy link
Contributor Author

voroyam commented Sep 25, 2018

done. We should communicate our work better @mmattel

@mmattel
Copy link
Contributor

mmattel commented Sep 25, 2018

True 😃
Still see that the file occ_command.adoc is present with changes (not fully reverted).
If fully reverted, the file should disappear from the change list...

Copy link
Contributor

@settermjd settermjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove modules/ROOT/pages/configuration/server/occ_command.adoc from the PR, as it only contains whitespace changes. Otherwise, lgtm.

@voroyam
Copy link
Contributor Author

voroyam commented Sep 25, 2018

Great, now I deleted the whole document in my PR.

That's the result of demanding something I don't know how to do.

@settermjd
Copy link
Contributor

It was less of a demand, more a kindly request. I'll sort it out.

@settermjd settermjd added enhancement New feature or request help wanted work in progress Still in development. Not to be merged. labels Sep 25, 2018
@mmattel
Copy link
Contributor

mmattel commented Sep 25, 2018

@voroyam the easiest would be you close that PR and create a new one containing the fix for user_configuration.adoc

settermjd
settermjd previously approved these changes Sep 26, 2018
voroyam and others added 2 commits September 26, 2018 12:39
In the upcoming 10.0.10 a user password cannot be set to "0".
@mmattel
Copy link
Contributor

mmattel commented Sep 26, 2018

This PR is now a bit messed up, because it contains an old version of occ_command.adoc which was updated in #113 (merged). Please either do what ever is necessary that the file will not longer be in the change list (maybe rebasing) or as already suggested close that PR an create a new one which only contains the changes for the user doc.

@settermjd settermjd closed this Sep 26, 2018
@mmattel
Copy link
Contributor

mmattel commented Sep 26, 2018

@voroyam
Could you create a new PR containaing only the changes made in user_configuration.adoc ?

Edit: superseeded by #124

@voroyam voroyam deleted the user-password-0 branch September 12, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request work in progress Still in development. Not to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants