Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no external icon urls in app registry #40955

Merged
merged 1 commit into from
Aug 30, 2023
Merged

fix: no external icon urls in app registry #40955

merged 1 commit into from
Aug 30, 2023

Conversation

DeepDiver1975
Copy link
Member

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs

This comment was marked as resolved.

Sign in to view
@DeepDiver1975 DeepDiver1975 force-pushed the fix/app-registry-icons branch 2 times, most recently from b423de2 to 49fbb32 Compare August 29, 2023 07:22
@DeepDiver1975 DeepDiver1975 force-pushed the fix/app-registry-icons branch from 49fbb32 to 373ef59 Compare August 29, 2023 10:24
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jnweiger
Copy link
Contributor

Patch works fine for me! /app/list/ now contains working local urls in all my test cases.
(But cannot test iOS)

@phil-davis phil-davis merged commit 88ec2c9 into master Aug 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/app-registry-icons branch August 30, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IljaN IljaN IljaN approved these changes

Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QA] AppRegistry loads icons from 3rd party URLs
4 participants
@DeepDiver1975 @jnweiger @IljaN @phil-davis