Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment of the maximum width of the appmenu #37760

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Conversation

ChrisEdS
Copy link
Contributor

@ChrisEdS ChrisEdS commented Jul 31, 2020

Description

After testing #37490 in RC7 I mentioned that the width of the menu becomes 5px too wide after adding more than 3 apps.

Motivation and Context

Prevent the menu from becoming wider than it needs to be with more than 3 entries.

How Has This Been Tested?

  • Manually tested in Chrome
  1. Add more then 3 apps into the menu.
    (F.ex. Activity, Market, External Sites)

Screenshots:

Before:
image

After:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Jul 31, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #37760 into release-10.5.0 will decrease coverage by 0.00%.
The diff coverage is 40.00%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.5.0   #37760      +/-   ##
====================================================
- Coverage             64.74%   64.74%   -0.01%     
- Complexity            19363    19365       +2     
====================================================
  Files                  1281     1281              
  Lines                 75628    75635       +7     
  Branches               1333     1333              
====================================================
+ Hits                  48966    48968       +2     
- Misses                26270    26275       +5     
  Partials                392      392              
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.92% <40.00%> (-0.01%) 19365.00 <0.00> (+2.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
apps/files/lib/App.php 20.00% <0.00%> (ø) 3.00 <0.00> (ø)
lib/private/Installer.php 47.74% <0.00%> (-0.44%) 87.00 <0.00> (+1.00) ⬇️
lib/private/legacy/app.php 62.30% <33.33%> (-0.20%) 176.00 <0.00> (+1.00) ⬇️
...e/AppFramework/DependencyInjection/DIContainer.php 63.67% <50.00%> (-0.13%) 15.00 <0.00> (ø)
version.php 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 382f192...9e97c80. Read the comment docs.

@ChrisEdS ChrisEdS requested a review from micbar July 31, 2020 12:29
@micbar micbar merged commit 2543724 into release-10.5.0 Jul 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-menue-width branch July 31, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants