Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Fix replacement usernames #37706

Merged
merged 2 commits into from
Jul 20, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 19, 2020

Description

When I do an acceptance test run with replacement usernames I get various test fails because some recently-added scenarios are not abstracting the username in the required places. So, for example, "Alice" is replaced with username "000" in PR #37506 but some Then steps fail because they expect hard-coded "Alice" when they should be expecting %username% which will be substituted at run-time for the actual replaced username.

  • Fix these so that they work properly when replacing the username.
  • Add some log output at the beginning of a test run when REPLACE_USERNAMES is defined. Show the username and user attribute replacements so that we know what was happening when we later lok at the log output.

How Has This Been Tested?

CI in PR #37506 passes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Jul 19, 2020
@phil-davis phil-davis changed the title [Tests-Only] Fix replacement usernames testing [Tests-Only] Fix replacement usernames Jul 19, 2020
@codecov
Copy link

codecov bot commented Jul 19, 2020

Codecov Report

Merging #37706 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37706   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
  Complexity    19386    19386           
=========================================
  Files          1283     1283           
  Lines         75730    75730           
  Branches       1333     1333           
=========================================
  Hits          49008    49008           
  Misses        26330    26330           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.89% <ø> (ø) 19386.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ab60a...02f27b1. Read the comment docs.

@phil-davis phil-davis marked this pull request as ready for review July 19, 2020 08:15
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants