Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only]Add acceptance tests to copy files over folder and vice versa #37701

Merged
merged 2 commits into from
Jul 18, 2020

Conversation

jasson99
Copy link
Contributor

Description

Add acceptance tests to copy files over folder and vice versa

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #37701 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37701   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
  Complexity    19386    19386           
=========================================
  Files          1283     1283           
  Lines         75730    75730           
  Branches       1333     1333           
=========================================
  Hits          49008    49008           
  Misses        26330    26330           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.89% <ø> (ø) 19386.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa0a2a...775ccda. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #37701 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37701   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
  Complexity    19386    19386           
=========================================
  Files          1283     1283           
  Lines         75730    75730           
  Branches       1333     1333           
=========================================
  Hits          49008    49008           
  Misses        26330    26330           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.89% <ø> (ø) 19386.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 347361d...1afe404. Read the comment docs.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are just a few places where we test for a folder, not a file.
Actually it makes no difference to the test code. But it will be a bit easier for people to read and understand what was expected to happen.

@phil-davis
Copy link
Contributor

This completes 3 of the 4 points in issue #37669

The last point "do these copy operations in a received user/group share" can be done in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants