Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Reviewed scenarios with tag @issue-ocis-reva-21 #37668

Merged
merged 1 commit into from
Jul 22, 2020
Merged

[Tests-Only] Reviewed scenarios with tag @issue-ocis-reva-21 #37668

merged 1 commit into from
Jul 22, 2020

Conversation

Talank
Copy link
Contributor

@Talank Talank commented Jul 8, 2020 •
edited by swoichha
Loading

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@Talank Talank self-assigned this Jul 8, 2020
@Talank Talank added the QA:team label Jul 8, 2020
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #37668 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37668   +/-   ##
=========================================
  Coverage     64.74%   64.74%           
- Complexity    19360    19363    +3     
=========================================
  Files          1281     1281           
  Lines         75622    75628    +6     
  Branches       1333     1333           
=========================================
+ Hits          48959    48966    +7     
+ Misses        26271    26270    -1     
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (+<0.01%) 19363.00 <ø> (+3.00)
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/util.php 74.95% <0.00%> (+0.42%) 222.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 752eda9...34ddd59. Read the comment docs.

4 similar comments
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #37668 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37668   +/-   ##
=========================================
  Coverage     64.74%   64.74%           
- Complexity    19360    19363    +3     
=========================================
  Files          1281     1281           
  Lines         75622    75628    +6     
  Branches       1333     1333           
=========================================
+ Hits          48959    48966    +7     
+ Misses        26271    26270    -1     
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (+<0.01%) 19363.00 <ø> (+3.00)
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/util.php 74.95% <0.00%> (+0.42%) 222.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 752eda9...34ddd59. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #37668 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37668   +/-   ##
=========================================
  Coverage     64.74%   64.74%           
- Complexity    19360    19363    +3     
=========================================
  Files          1281     1281           
  Lines         75622    75628    +6     
  Branches       1333     1333           
=========================================
+ Hits          48959    48966    +7     
+ Misses        26271    26270    -1     
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (+<0.01%) 19363.00 <ø> (+3.00)
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/util.php 74.95% <0.00%> (+0.42%) 222.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 752eda9...34ddd59. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #37668 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37668   +/-   ##
=========================================
  Coverage     64.74%   64.74%           
- Complexity    19360    19363    +3     
=========================================
  Files          1281     1281           
  Lines         75622    75628    +6     
  Branches       1333     1333           
=========================================
+ Hits          48959    48966    +7     
+ Misses        26271    26270    -1     
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (+<0.01%) 19363.00 <ø> (+3.00)
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/util.php 74.95% <0.00%> (+0.42%) 222.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 752eda9...34ddd59. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #37668 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37668   +/-   ##
=========================================
  Coverage     64.74%   64.74%           
- Complexity    19360    19363    +3     
=========================================
  Files          1281     1281           
  Lines         75622    75628    +6     
  Branches       1333     1333           
=========================================
+ Hits          48959    48966    +7     
+ Misses        26271    26270    -1     
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (+<0.01%) 19363.00 <ø> (+3.00)
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/util.php 74.95% <0.00%> (+0.42%) 222.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 752eda9...34ddd59. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 8, 2020 •
edited
Loading

Codecov Report

Merging #37668 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37668   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
  Complexity    19386    19386           
=========================================
  Files          1283     1283           
  Lines         75730    75730           
  Branches       1333     1333           
=========================================
  Hits          49008    49008           
  Misses        26330    26330           
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.89% <ø> (ø) 19386.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c16d68...b7cb71d. Read the comment docs.

@Talank Talank force-pushed the reviewIssueOcisReva21 branch 3 times, most recently from 392c338 to f589730 Compare July 14, 2020 04:51
@swoichha swoichha force-pushed the reviewIssueOcisReva21 branch from f589730 to bf0a925 Compare July 14, 2020 07:46
@Talank Talank force-pushed the reviewIssueOcisReva21 branch 2 times, most recently from 5b24480 to 7cf8391 Compare July 17, 2020 16:44
@Talank Talank marked this pull request as ready for review July 21, 2020 07:41
@individual-it
Copy link
Member

please squash all the commits and merge

@Talank Talank force-pushed the reviewIssueOcisReva21 branch from 17b8b73 to 842e450 Compare July 21, 2020 10:43
@Talank Talank force-pushed the reviewIssueOcisReva21 branch from 842e450 to b7cb71d Compare July 21, 2020 10:44
@Talank Talank merged commit 1faea51 into master Jul 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the reviewIssueOcisReva21 branch July 22, 2020 02:05
This was referenced Jul 22, 2020
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@Talank Talank

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

listing shares via ocs API is not possible
3 participants
@Talank @individual-it @phil-davis