Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] check HTTP status code in favorite tests #37543

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

individual-it
Copy link
Member

Description

check the HTTP status code

Motivation and Context

when testing OCIS with EOS, the status is 500, but I had to debug first to find it out, better the tests would tell me directly

How Has This Been Tested?

owncloud/ocis#321
owncloud/ocis-reva#277

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #37543 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37543   +/-   ##
=========================================
  Coverage     64.67%   64.67%           
  Complexity    19339    19339           
=========================================
  Files          1279     1279           
  Lines         75573    75573           
  Branches       1331     1331           
=========================================
  Hits          48880    48880           
  Misses        26301    26301           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.84% <ø> (ø) 19339.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05bf8c8...c9dcff5. Read the comment docs.

@phil-davis phil-davis merged commit e09aab4 into master Jun 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the check-http-status-code-fav branch June 17, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants