Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Adjust usernames in UI tests #37395

Merged
merged 1 commit into from
May 16, 2020

Conversation

phil-davis
Copy link
Contributor

Description

Adjust the UI tests so that user0 is the primary actor.

Related Issue

Part of issue #33596

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis
Copy link
Contributor Author

Note: this does not touch any API tests, so it should not effect ocis or ocis-reva testing.
But anyway, these PRs check that:

owncloud/ocis#280

owncloud/ocis-reva#205

@phil-davis phil-davis force-pushed the adjust-usernames-in-UI-tests branch from 29bfe50 to 601e795 Compare May 16, 2020 07:50
@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #37395 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37395   +/-   ##
=========================================
  Coverage     64.57%   64.57%           
  Complexity    19222    19222           
=========================================
  Files          1268     1268           
  Lines         75107    75107           
  Branches       1331     1331           
=========================================
  Hits          48498    48498           
  Misses        26217    26217           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.73% <ø> (ø) 19222.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a08957...601e795. Read the comment docs.

@individual-it individual-it merged commit 8252ffa into master May 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the adjust-usernames-in-UI-tests branch May 16, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants