Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Adjust user roles in acceptance tests #37392

Merged
merged 1 commit into from
May 15, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented May 15, 2020

Description

This is the same sort of changes as PR #37377

Finishes the remaining API and CLI test suites.

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Comment on lines +2305 to +2306
$this->ocsContext->userSendsHTTPMethodToOcsApiEndpointWithBody(
$user, "DELETE", $url, null
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this was an existing problem. The delete request was being sent with the authentication for the "current user" rather than the specified user. If the 2 were the same, then everything worked OK. With refactoring and removing Given as user "user0" in some scenarios, they now did not default to the expected/correct user.

@phil-davis phil-davis marked this pull request as ready for review May 15, 2020 07:23
@phil-davis phil-davis requested a review from individual-it May 15, 2020 07:24
@phil-davis phil-davis force-pushed the adjust-user-roles-in-acceptance-tests-2 branch from 386d94e to 810a269 Compare May 15, 2020 07:58
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #37392 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37392   +/-   ##
=========================================
  Coverage     64.57%   64.57%           
  Complexity    19220    19220           
=========================================
  Files          1268     1268           
  Lines         75105    75105           
  Branches       1331     1331           
=========================================
  Hits          48496    48496           
  Misses        26217    26217           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.72% <ø> (ø) 19220.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e348ec...810a269. Read the comment docs.

@phil-davis phil-davis merged commit 91c7786 into master May 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the adjust-user-roles-in-acceptance-tests-2 branch May 15, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants