[Tests-Only] Adjust user roles in API acceptance tests #37377

phil-davis · 2020-05-12T08:25:28Z

Description

Adjusts acceptance test scenarios so that the "standard" usernames are used in a standard way:

tests that have just a single ordinary user use user0
sharing tests have user0 share to user1
resharing tests then have user resharing to user2 ...
tests that create and test an extra admin account use another-admin or a subadmin use subadmin another-subadmin
tests that create and modify attributes of an ordinary account use brand-new-user then another-new-user and similar for groups brand-new-group and another-new-group (e.g. Provisioning API tests) (names subject to change!)
tests that check API calls to a non-existent user use nonexistentuser and for groups nonexistentgroup

The "primary actor" in most scenarios is either admin or user0

This will make it easier to choose substitute usernames (UIDs) and be confident that all the test scenarios are being run in some sensible way with the substitutions.

This PR has changes for test suites apiAuth through to apiShareManagementBasic.

Related Issue

#33596

How Has This Been Tested?

CI

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

codecov · 2020-05-12T09:53:48Z

Codecov Report

Merging #37377 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37377   +/-   ##
=========================================
  Coverage     64.57%   64.57%           
  Complexity    19220    19220           
=========================================
  Files          1268     1268           
  Lines         75105    75105           
  Branches       1331     1331           
=========================================
  Hits          48496    48496           
  Misses        26217    26217           
  Partials        392      392

Flag	Coverage Δ	Complexity Δ
#javascript	`54.14% <ø> (ø)`	`0.00 <ø> (ø)`
#phpunit	`65.72% <ø> (ø)`	`19220.00 <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5301af6...f1816bd. Read the comment docs.

individual-it

looks good, but please make a PR to ocis & ocis-reva with this branch as test-runner to prove that it works there

phil-davis · 2020-10-16T16:31:01Z

tests/acceptance/features/apiProvisioning-v1/getUser.feature

    Then the OCS status code should be "100"
    And the HTTP status code should be "200"
    And the display name returned by the API should be "New User"
    And the quota definition returned by the API should be "default"

  Scenario: a normal user gets their own information, providing uppercase username as authentication
    Given these users have been created with default attributes and skeleton files:
-      | username | displayname |
-      | newuser  | New User    |
-    When user "NEWUSER" retrieves the information of user "newuser" using the provisioning API


The uppercase has got lost here - see issue #38014

phil-davis · 2020-10-16T16:31:11Z

tests/acceptance/features/apiProvisioning-v1/getUser.feature

@@ -111,9 +111,9 @@ Feature: get user
  @skipOnOcV10.3
  Scenario: a normal user gets their own information, providing uppercase username in the URL
    Given these users have been created with default attributes and skeleton files:
-      | username | displayname |
-      | newuser  | New User    |
-    When user "newuser" retrieves the information of user "NEWUSER" using the provisioning API


The uppercase has got lost here - see issue #38014

phil-davis · 2020-10-16T16:31:29Z

tests/acceptance/features/apiProvisioning-v1/getUser.feature

@@ -122,19 +122,19 @@ Feature: get user
  @skipOnOcV10.3
  Scenario: a mixed-case normal user gets their own information, providing lowercase username in the URL
    Given these users have been created with default attributes and skeleton files:
-      | username | displayname |
-      | NewUser  | New User    |
-    When user "NewUser" retrieves the information of user "newuser" using the provisioning API


The mixed case has got lost here - see issue #38014

phil-davis · 2020-10-16T16:31:47Z

tests/acceptance/features/apiProvisioning-v1/getUser.feature

    Then the OCS status code should be "100"
    And the HTTP status code should be "200"
    And the display name returned by the API should be "New User"
    And the quota definition returned by the API should be "default"

  Scenario: a mixed-case normal user gets their own information, providing the mixed-case username in the URL
    Given these users have been created with default attributes and skeleton files:
-      | username | displayname |
-      | NewUser  | New User    |
-    When user "newuser" retrieves the information of user "NewUser" using the provisioning API


The mixed case has got lost here - see issue #38014

phil-davis · 2020-10-16T16:32:40Z

tests/acceptance/features/apiProvisioning-v2/getUser.feature

    Then the OCS status code should be "200"
    And the HTTP status code should be "200"
    And the display name returned by the API should be "New User"
    And the quota definition returned by the API should be "default"

  Scenario: a normal user gets their own information, providing uppercase username as authentication
    Given these users have been created with default attributes and skeleton files:
-      | username | displayname |
-      | newuser  | New User    |
-    When user "NEWUSER" retrieves the information of user "newuser" using the provisioning API


The uppercase has got lost here - see issue #38014

phil-davis · 2020-10-16T16:32:48Z

tests/acceptance/features/apiProvisioning-v2/getUser.feature

@@ -113,9 +113,9 @@ Feature: get user
  @skipOnOcV10.3
  Scenario: a normal user gets their own information, providing uppercase username in the URL
    Given these users have been created with default attributes and skeleton files:
-      | username | displayname |
-      | newuser  | New User    |
-    When user "newuser" retrieves the information of user "NEWUSER" using the provisioning API


The uppercase has got lost here - see issue #38014

phil-davis · 2020-10-16T16:33:00Z

tests/acceptance/features/apiProvisioning-v2/getUser.feature

@@ -124,19 +124,19 @@ Feature: get user
  @skipOnOcV10.3
  Scenario: a mixed-case normal user gets their own information, providing lowercase username in the URL
    Given these users have been created with default attributes and skeleton files:
-      | username | displayname |
-      | NewUser  | New User    |
-    When user "NewUser" retrieves the information of user "newuser" using the provisioning API


The mixed case has got lost here - see issue #38014

phil-davis · 2020-10-16T16:33:15Z

tests/acceptance/features/apiProvisioning-v2/getUser.feature

    Then the OCS status code should be "200"
    And the HTTP status code should be "200"
    And the display name returned by the API should be "New User"
    And the quota definition returned by the API should be "default"

  Scenario: a mixed-case normal user gets their own information, providing the mixed-case username in the URL
    Given these users have been created with default attributes and skeleton files:
-      | username | displayname |
-      | NewUser  | New User    |
-    When user "newuser" retrieves the information of user "NewUser" using the provisioning API


The mixed case has got lost here - see issue #38014

phil-davis added 2 - Developing dev:acceptance-tests QA:team labels May 12, 2020

phil-davis self-assigned this May 12, 2020

phil-davis changed the title ~~[Tests-Only] [WIP] Adjust user roles in API acceptance tests (1)~~ [Tests-Only] [WIP] Adjust user roles in API acceptance tests May 12, 2020

phil-davis force-pushed the adjust-user-roles-in-acceptance-tests branch 5 times, most recently from 26f02fd to 5bc1263 Compare May 14, 2020 05:08

phil-davis added 3 commits May 14, 2020 13:50

Adjust user roles in API acceptance tests (1)

c4957fd

adjust apiShareCreateSpecial features

2db0dff

adjust apiShare features (1)

f1816bd

phil-davis force-pushed the adjust-user-roles-in-acceptance-tests branch from efdff15 to f1816bd Compare May 14, 2020 08:07

phil-davis added 3 - To Review and removed 2 - Developing labels May 14, 2020

phil-davis requested a review from individual-it May 14, 2020 11:00

phil-davis changed the title ~~[Tests-Only] [WIP] Adjust user roles in API acceptance tests~~ [Tests-Only] Adjust user roles in API acceptance tests May 14, 2020

phil-davis marked this pull request as ready for review May 14, 2020 11:02

individual-it approved these changes May 14, 2020

View reviewed changes

This was referenced May 14, 2020

[Tests-Only] [Do not merge] test-adjust-user-roles-in-acceptance-tests owncloud/ocis#278

Closed

[Tests-Only] [Do not merge] test-adjust-user-roles-in-acceptance-tests owncloud/ocis-reva#202

Closed

phil-davis merged commit 1e348ec into master May 14, 2020

delete-merged-branch bot deleted the adjust-user-roles-in-acceptance-tests branch May 14, 2020 11:52

This was referenced May 14, 2020

[Tests-Only] Acceptance tests for user with unusual names provided as env variable #37332

Merged

[Tests-Only] Adjust user roles in acceptance tests #37392

Merged

phil-davis mentioned this pull request Oct 16, 2020

Fix mixed-case username test scenarios #38014

Closed

phil-davis commented Oct 16, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tests-Only] Adjust user roles in API acceptance tests #37377

[Tests-Only] Adjust user roles in API acceptance tests #37377

phil-davis commented May 12, 2020 •

edited

Loading

codecov bot commented May 12, 2020 •

edited

Loading

individual-it left a comment

phil-davis Oct 16, 2020

phil-davis Oct 16, 2020

phil-davis Oct 16, 2020

phil-davis Oct 16, 2020

phil-davis Oct 16, 2020

phil-davis Oct 16, 2020

phil-davis Oct 16, 2020

phil-davis Oct 16, 2020

[Tests-Only] Adjust user roles in API acceptance tests #37377

[Tests-Only] Adjust user roles in API acceptance tests #37377

Conversation

phil-davis commented May 12, 2020 • edited Loading

Description

Related Issue

How Has This Been Tested?

Types of changes

Checklist:

codecov bot commented May 12, 2020 • edited Loading

Codecov Report

individual-it left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

phil-davis commented May 12, 2020 •

edited

Loading

codecov bot commented May 12, 2020 •

edited

Loading