Fix to allow sharing with UID that is an integer

[phil-davis]

Description

TBD - I will add some UI acceptance test cases also.

Related Issue

• Fixes Can't share with user that only has numbers as name #37324

How Has This Been Tested?

• unit tests
• manually sharing in the UI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[codecov]

Codecov Report

Merging #37327 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master   #37327   +/-   ##
=========================================
  Coverage     64.53%   64.53%           
- Complexity    19167    19168    +1     
=========================================
  Files          1266     1266           
  Lines         74957    74959    +2     
  Branches       1331     1331           
=========================================
+ Hits          48373    48376    +3     
+ Misses        26192    26191    -1     
  Partials        392      392           

Flag	Coverage Δ	Complexity Δ
#javascript	54.14% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.69% <100.00%> (+<0.01%)	19168.00 <0.00> (+1.00)

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Share20/Share.php	96.66% <100.00%> (+0.72%)	65.00 <0.00> (+1.00)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cd0dc7...eac86e9. Read the comment docs.

[phil-davis]

@karakayasemi please feel free to work on this - take whatever test code and other code is useful.
As discussed in the issue, maybe incoming data in the JSON like shareWith=1.200 needs to be parsed earlier so that 1.200 can be made into string "1.200" to avoid it ever actually turning into a float where we cannot then know if it was "1.2" or "1.20" or "1.200"

[karakayasemi]

@phil-davis I see your point on the float type. Probably, shareWith: 1.200 is evaluated as shareWith: 1.2 in the client side before reaching the server. I do not think, we need to spend time to fix all client errors, correcting only numeric values are enough as you suggest.

For this PR, I want to correct js request and send shareWith parameter as string in JSON-encoded payload. Also, instead of changing an interface, controller can cast request parameter to string and call the interface method with correct type.
I will prepare a commit with these changes in the day.

[phil-davis]

See #37336 for the next approach.