[Tests-Only] Bump phpunit/phpunit from 7.5.20 to 8.5.4 #37307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 7.5.20 to 8.5.4. - [Release notes](https://github.com/sebastianbergmann/phpunit/releases) - [Changelog](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-8.5.md) - [Commits](sebastianbergmann/phpunit@7.5.20...8.5.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
phil-davis
approved these changes
Apr 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #37307 +/- ##
=========================================
Coverage 64.53% 64.53%
Complexity 19166 19166
=========================================
Files 1266 1266
Lines 74952 74952
Branches 1331 1331
=========================================
Hits 48372 48372
Misses 26188 26188
Partials 392 392
Continue to review full report at Codecov.
|
|
The phpunit warnings that needed to be fixed were: |
phil-davis
reviewed
Apr 26, 2020
Comment on lines
+85
to
+87
| public function __construct($parameters) { | ||
| } | ||
|
|
There was a problem hiding this comment.
This was needed because of: https://drone.owncloud.com/owncloud/core/24405/13/9
PHPUnit 8.5.3 by Sebastian Bergmann and contributors.
Runtime: PHPDBG 7.2.27-6+ubuntu18.04.1+deb.sury.org+1
Configuration: /drone/src/tests/phpunit-autotest.xml
............................................................. 61 / 9984 ( 0%)
........................S.................................... 122 / 9984 ( 1%)
............................................................. 183 / 9984 ( 1%)
............................................................. 244 / 9984 ( 2%)
............................................................. 305 / 9984 ( 3%)
............................................................. 366 / 9984 ( 3%)
............................................................. 427 / 9984 ( 4%)
............................................................. 488 / 9984 ( 4%)
............................................................. 549 / 9984 ( 5%)
............................................................. 610 / 9984 ( 6%)
............................................................. 671 / 9984 ( 6%)
............................................................. 732 / 9984 ( 7%)
............................................................. 793 / 9984 ( 7%)
............................................................. 854 / 9984 ( 8%)
............................................................. 915 / 9984 ( 9%)
............................................................. 976 / 9984 ( 9%)
............................................................. 1037 / 9984 ( 10%)
.......................S........SS........................... 1098 / 9984 ( 10%)
............................................................. 1159 / 9984 ( 11%)
............................................................. 1220 / 9984 ( 12%)
............................................................. 1281 / 9984 ( 12%)
............................................................. 1342 / 9984 ( 13%)
............................................................. 1403 / 9984 ( 14%)
............................................................. 1464 / 9984 ( 14%)
............................................................. 1525 / 9984 ( 15%)
............................................................. 1586 / 9984 ( 15%)
............................................................. 1647 / 9984 ( 16%)
............................................................. 1708 / 9984 ( 17%)
............................................................. 1769 / 9984 ( 17%)
............................................................. 1830 / 9984 ( 18%)
............................................................. 1891 / 9984 ( 18%)
............................................................. 1952 / 9984 ( 19%)
............................................................. 2013 / 9984 ( 20%)
..
[PHP Fatal error: Class Mock_Common_a6b4666b contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (OCP\Files\Storage::__construct) in /drone/src/lib/composer/phpunit/phpunit/src/Framework/MockObject/MockClass.php(42) : eval()'d code on line 3]
PHPunit 8 had trouble mocking the constructor of an abstract class, when the constructor itself is abstract. Putting a "dummy" implementation here helped it. Classes that extend Common implement their own constructor anyway, which will override this.
This was referenced Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps phpunit/phpunit from 7.5.20 to 8.5.4.
Changelog
Sourced from phpunit/phpunit's changelog.
Commits
8474e22Prepare release1b02a08Update Psalm baselineb84b397Fix wrong phpdoccb13599Document fluent methods as such1cc2dcfUpdate tools7482fe2Update tools7b52d01Update testsa6999a6Use @psalm-var instead of @var (so that PHP-CS-Fixer does not touch these)47d3358Fix CS/WS issuesd88df6cUpdate toolsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: