Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hasUpdated for webdav storage #37300

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Apr 24, 2020

Description

Unit tests get this fail on PHP 7.4

There was 1 failure:

1) Test\Files\Storage\DavTest::testHasUpdated with data set #4 (array('"oldetag"', 1), array('oldetag', 31), true)
Failed asserting that false matches expected true.

/drone/src/tests/lib/Files/Storage/DavTest.php:1306

Adjust the code so that it checks more carefully for non-existent array indexes etc.

The commit has been cherry-picked from PR #37280 where the demostration of PHP 7.4 tests is happening.

Note: there are no individual changelog entries being done for these PHP 7.4 code refactorings. An overall changelog entry for PHP 7.4 support will happen at the end.

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Apr 24, 2020
@owncloud owncloud deleted a comment from update-docs bot Apr 24, 2020
@phil-davis phil-davis mentioned this pull request Apr 24, 2020
11 tasks
@phil-davis phil-davis merged commit 953df17 into master Apr 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-hasUpdated-for-webdav-storage branch April 24, 2020 04:27
@phil-davis phil-davis mentioned this pull request Apr 24, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants