Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check get result against false when removing file from cache #37281

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Apr 20, 2020

Description

This is critical for unit tests to pass with PHP 7.4

Related Issue

https://github.com/owncloud/enterprise/issues/3967

Motivation and Context

Many unit tests are failing for PHP 7.4
Before https://drone.owncloud.com/owncloud/core/24348/24/9:

Tests: 9984, Assertions: 57374, Errors: 153, Failures: 1, Skipped: 79.

After https://drone.owncloud.com/owncloud/core/24349/24/9

 Tests: 9984, Assertions: 57729, Errors: 44, Failures: 1, Skipped: 79.

How Has This Been Tested?

By CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@VicDeo VicDeo added this to the development milestone Apr 20, 2020
@VicDeo VicDeo self-assigned this Apr 20, 2020
@update-docs
Copy link

update-docs bot commented Apr 20, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #37281 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37281   +/-   ##
=========================================
  Coverage     64.52%   64.52%           
- Complexity    19155    19156    +1     
=========================================
  Files          1266     1266           
  Lines         74912    74913    +1     
  Branches       1331     1331           
=========================================
+ Hits          48340    48341    +1     
  Misses        26180    26180           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.68% <100.00%> (+<0.01%) 19156.00 <0.00> (+1.00)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Cache.php 97.64% <100.00%> (+<0.01%) 107.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 680894d...1bbcb26. Read the comment docs.

@phil-davis phil-davis merged commit b52a650 into master Apr 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the check-cache-against-false branch April 21, 2020 02:23
This was referenced Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants