Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Php 7.4 fix phpunit #37280

Closed
wants to merge 4 commits into from
Closed

[Tests-Only] Php 7.4 fix phpunit #37280

wants to merge 4 commits into from

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Apr 20, 2020

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@VicDeo VicDeo self-assigned this Apr 20, 2020
@phil-davis
Copy link
Contributor

@VicDeo I merged PR #37281 and there were some other unrelated dependency updates overnight that are merged PR #37283
Also PR #37279 is waiting for review and merge - you might like to review that first and merge if it looks OK.

Then you can rebase this PR and get a new run of phpunit with less errors reported.

@VicDeo VicDeo force-pushed the php-7.4-fix-phpunit branch 2 times, most recently from 23cb107 to bc737a2 Compare April 21, 2020 08:14
@phil-davis phil-davis mentioned this pull request Apr 21, 2020
Closed
@VicDeo VicDeo force-pushed the php-7.4-fix-phpunit branch 9 times, most recently from e2d65e6 to 3534d51 Compare April 23, 2020 13:43
@VicDeo VicDeo force-pushed the php-7.4-fix-phpunit branch from 3534d51 to 540b0cc Compare April 23, 2020 16:16
@VicDeo VicDeo force-pushed the php-7.4-fix-phpunit branch from 0cd9e0a to 0f86aa4 Compare April 23, 2020 21:07
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #37280 into master will decrease coverage by 0.03%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37280      +/-   ##
============================================
- Coverage     64.52%   64.48%   -0.04%     
  Complexity    19166    19166              
============================================
  Files          1266     1266              
  Lines         74936    74952      +16     
  Branches       1331     1331              
============================================
- Hits          48354    48335      -19     
- Misses        26190    26225      +35     
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.64% <55.55%> (-0.05%) 19166.00 <0.00> (ø)
Impacted Files Coverage Δ Complexity Δ
console.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
index.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
lib/private/Files/Storage/DAV.php 78.77% <100.00%> (+0.70%) 0.00 <0.00> (ø)
...ternal/lib/Controller/GlobalStoragesController.php 45.88% <0.00%> (-21.18%) 0.00% <0.00%> (ø%)
...external/lib/Controller/UserStoragesController.php 56.97% <0.00%> (-13.96%) 0.00% <0.00%> (ø%)
...les_external/lib/Controller/StoragesController.php 47.10% <0.00%> (-5.08%) 0.00% <0.00%> (ø%)
lib/private/Share20/DefaultShareProvider.php 97.74% <0.00%> (-0.16%) 120.00% <0.00%> (ø%)
settings/routes.php 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
lib/private/OCS/Provider.php 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
apps/files/appinfo/routes.php 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e1e3e...0f86aa4. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #37280 into master will decrease coverage by 0.03%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37280      +/-   ##
============================================
- Coverage     64.52%   64.48%   -0.04%     
  Complexity    19166    19166              
============================================
  Files          1266     1266              
  Lines         74936    74952      +16     
  Branches       1331     1331              
============================================
- Hits          48354    48335      -19     
- Misses        26190    26225      +35     
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.64% <55.55%> (-0.05%) 19166.00 <0.00> (ø)
Impacted Files Coverage Δ Complexity Δ
console.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
index.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
lib/private/Files/Storage/DAV.php 78.77% <100.00%> (+0.70%) 0.00 <0.00> (ø)
...ternal/lib/Controller/GlobalStoragesController.php 45.88% <0.00%> (-21.18%) 0.00% <0.00%> (ø%)
...external/lib/Controller/UserStoragesController.php 56.97% <0.00%> (-13.96%) 0.00% <0.00%> (ø%)
...les_external/lib/Controller/StoragesController.php 47.10% <0.00%> (-5.08%) 0.00% <0.00%> (ø%)
lib/private/Share20/DefaultShareProvider.php 97.74% <0.00%> (-0.16%) 120.00% <0.00%> (ø%)
settings/routes.php 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
lib/private/OCS/Provider.php 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
apps/files/appinfo/routes.php 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e1e3e...0f86aa4. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #37280 into master will decrease coverage by 0.03%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37280      +/-   ##
============================================
- Coverage     64.52%   64.48%   -0.04%     
  Complexity    19166    19166              
============================================
  Files          1266     1266              
  Lines         74936    74952      +16     
  Branches       1331     1331              
============================================
- Hits          48354    48335      -19     
- Misses        26190    26225      +35     
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.64% <55.55%> (-0.05%) 19166.00 <0.00> (ø)
Impacted Files Coverage Δ Complexity Δ
console.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
index.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
lib/private/Files/Storage/DAV.php 78.77% <100.00%> (+0.70%) 0.00 <0.00> (ø)
...ternal/lib/Controller/GlobalStoragesController.php 45.88% <0.00%> (-21.18%) 0.00% <0.00%> (ø%)
...external/lib/Controller/UserStoragesController.php 56.97% <0.00%> (-13.96%) 0.00% <0.00%> (ø%)
...les_external/lib/Controller/StoragesController.php 47.10% <0.00%> (-5.08%) 0.00% <0.00%> (ø%)
lib/private/Share20/DefaultShareProvider.php 97.74% <0.00%> (-0.16%) 120.00% <0.00%> (ø%)
settings/routes.php 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
lib/private/OCS/Provider.php 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
apps/files/appinfo/routes.php 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e1e3e...0f86aa4. Read the comment docs.

@phil-davis phil-davis mentioned this pull request Apr 24, 2020
Merged
11 tasks
@phil-davis
Copy link
Contributor

@VicDeo I cherry-picked the last commit into #37300 so that ordinary CI can run for that and it can get merged this morning.

Congratulations on getting CI passing! Now we can think about a real PR that adjusts CI permanently for master PHP 7.4 support.

@phil-davis phil-davis mentioned this pull request Apr 24, 2020
Closed
4 tasks
@phil-davis
Copy link
Contributor

See PR #37302 for a PR to enable PHP 7.4 in core. IMO CI should pass there.

@VicDeo
Copy link
Member Author

VicDeo commented Apr 24, 2020

All known issues have been fixed. it's time to close

@VicDeo VicDeo closed this Apr 24, 2020
@VicDeo VicDeo deleted the php-7.4-fix-phpunit branch April 24, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VicDeo VicDeo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VicDeo @phil-davis