Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-only] don't check LDAP SSL cert #36945

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Feb 12, 2020

Description

don't check the LDAP SSL Cert when using the SSL port of LDAP in the tests

Related Issue

owncloud/ocis-reva#80 (comment)

How Has This Been Tested?

running tests on ocis with default ldap settings

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #36945 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #36945      +/-   ##
============================================
+ Coverage     64.29%   64.38%   +0.09%     
  Complexity    19135    19135              
============================================
  Files          1270     1270              
  Lines         74872    74872              
  Branches       1329     1329              
============================================
+ Hits          48137    48210      +73     
+ Misses        26344    26271      -73     
  Partials        391      391
Flag Coverage Δ Complexity Δ
#javascript 54.17% <ø> (-45.83%) 0 <ø> (ø)
#phpunit 65.52% <ø> (+0.32%) 19135 <ø> (-894) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/systemtags/js/filesplugin.js 40% <0%> (ø) 0% <0%> (ø) ⬇️
core/js/systemtags/systemtags.js 90% <0%> (ø) 0% <0%> (ø) ⬇️
apps/files_sharing/js/share.js 72.44% <0%> (ø) 0% <0%> (ø) ⬇️
core/js/mimetypelist.js 100% <0%> (ø) 0% <0%> (ø) ⬇️
settings/js/setpassword.js 66.66% <0%> (ø) 0% <0%> (ø) ⬇️
apps/files_external/js/statusmanager.js 1.08% <0%> (ø) 0% <0%> (ø) ⬇️
lib/private/DB/PostgreSqlMigrator.php 0% <0%> (-100%) 4% <0%> (ø)
...ilder/ExpressionBuilder/PgSqlExpressionBuilder.php 0% <0%> (-88.89%) 3% <0%> (ø)
lib/private/DB/AdapterPgSql.php 0% <0%> (-85.72%) 2% <0%> (ø)
apps/comments/js/app.js 66.66% <0%> (ø) 0% <0%> (ø) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61382da...eda5546. Read the comment docs.

@individual-it individual-it merged commit d082913 into master Feb 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the dontCheckLDAPCert branch February 12, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants