-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the wording in the additional tab to not confuse users #36775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and needs a changelog
has been done
6a82bef
to
40778b7
Compare
Codecov Report
@@ Coverage Diff @@
## master #36775 +/- ##
=========================================
Coverage 64.92% 64.92%
Complexity 19151 19151
=========================================
Files 1267 1267
Lines 74902 74902
Branches 1331 1331
=========================================
Hits 48633 48633
Misses 25877 25877
Partials 392 392
Continue to review full report at Codecov.
|
I added 1 word and added a changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text is fine. Thanks for taking care everybody 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be decided when to merge.
Currently it would go into 10.4 but we didn't update the translations.
40778b7
to
d341da7
Compare
Note: PR #36776 changed the word "Error" to "Other" on that page. So that "fixed" it for 10.4. I rebased this just now. After 10.4 is released, someone can decide if they would like to have the words in this PR, and merge it. |
@phil-davis thanks. I think everybody agreed on the solution. |
Ping ? |
This is waiting until after 10.4.0 is released. 10.4.0 changed the word "Error" to "Other", which at least gets rid of the misleading word "Error". If we had realised how long it would be until we got 10.4.0 released, then we could have merged this and the new translations would have had plenty of time to be done. Anyway, too late for that now. |
ea2a2bb
to
bf0aefa
Compare
I rebased this and adjusted the words of the changelog entry. |
bf0aefa
to
12e8fea
Compare
This missed out on 10.4.1 |
Nobody merged this. |
Description
This PR changes two strings that caused confusion in the additional tab.
Related Issue
Motivation and Context
Confusion should be avoided.
Types of changes
Checklist: