Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Php7.4 20191130 #36500

Closed
wants to merge 11 commits into from
Closed

Php7.4 20191130 #36500

wants to merge 11 commits into from

Conversation

phil-davis
Copy link
Contributor

Try running tests with PHP 7.4

@phil-davis phil-davis self-assigned this Nov 30, 2019
@codecov
Copy link

codecov bot commented Dec 2, 2019 •
edited
Loading

Codecov Report

Merging #36500 into master will increase coverage by 1.16%.
The diff coverage is 20%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #36500      +/-   ##
============================================
+ Coverage     64.68%   65.84%   +1.16%     
- Complexity    19105    19268     +163     
============================================
  Files          1269     1222      -47     
  Lines         74721    71720    -3001     
  Branches       1320     1320              
============================================
- Hits          48333    47224    -1109     
+ Misses        26000    24108    -1892     
  Partials        388      388
Flag Coverage Δ Complexity Δ
#javascript 54.12% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.2% <20%> (+1.34%) 19268 <0> (+163) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Cache.php 97.57% <ø> (ø) 104 <0> (ø) ⬇️
index.php 0% <0%> (ø) 0 <0> (ø) ⬇️
console.php 0% <0%> (ø) 0 <0> (ø) ⬇️
...AppFramework/Utility/ControllerMethodReflector.php 100% <100%> (ø) 10 <0> (ø) ⬇️
...ivate/Files/ObjectStore/HomeObjectStoreStorage.php 0% <0%> (-86.67%) 8% <0%> (ø)
lib/private/Files/Storage/Wrapper/Availability.php 10.38% <0%> (-40.26%) 80% <0%> (ø)
lib/private/Files/ObjectStore/NoopScanner.php 68.75% <0%> (-18.75%) 6% <0%> (ø)
lib/private/Preview/MP3.php 45.16% <0%> (-12.91%) 13% <0%> (ø)
lib/private/Autoloader.php 80.48% <0%> (-12.2%) 20% <0%> (ø)
...b/private/Files/ObjectStore/ObjectStoreStorage.php 66.2% <0%> (-11.04%) 105% <0%> (ø)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc91aa...fa1fe6c. Read the comment docs.

@phil-davis
Copy link
Contributor Author

This has lots of phpunit messages that will need to be looked into. So it is not a simple 10-minute job for this week!

@phil-davis phil-davis mentioned this pull request Dec 3, 2019
Closed
4 tasks
@phil-davis phil-davis force-pushed the php7.4-20191130 branch 5 times, most recently from c9175b7 to a469f96 Compare December 12, 2019 12:58
@phil-davis
Copy link
Contributor Author

litmus and webDAV problem with object __toString conversion exception - see #32670 (comment)

@phil-davis phil-davis mentioned this pull request Dec 13, 2019
Merged
@phil-davis phil-davis force-pushed the php7.4-20191130 branch 2 times, most recently from d59e5b1 to b6f44e4 Compare December 19, 2019 07:37
@phil-davis phil-davis force-pushed the php7.4-20191130 branch 2 times, most recently from 1368534 to 6195fc7 Compare December 30, 2019 08:24
@phil-davis
Copy link
Contributor Author

see #36670

@phil-davis phil-davis closed this Jan 1, 2020
@phil-davis phil-davis deleted the php7.4-20191130 branch June 18, 2020 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@phil-davis phil-davis

Labels
2 - Developing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@phil-davis