[stable10] Return "password fields" only if public-link password is set

[IljaN]

Description

Show "share_with" and "share_with_displayname" fields for public-links only if a share-password
is set.

Related Issue

• Fixes Share20OcsController no longer provides info whether public link share is password-protected #35541
• Caused by [stable10] Dont't expose hashed password in ocs api #34691

Motivation and Context

The iOS client uses the presence of these fields to determine if a password is required. Despite their names they are historically used to store pw-hashes for public-links.

Due to a recent security fix (31b47dc) which replaced the hashes with ***redacted***, share_with and share_with_displayname was never null thus for the client it looked like all links have passwords.

How Has This Been Tested?

Adjusted acceptance tests

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport [master] Return "password fields" only if public-link password is set. #35545

[codecov]

Codecov Report

Merging #35544 into stable10 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable10   #35544      +/-   ##
==============================================
+ Coverage        64.8%   64.81%   +<.01%     
- Complexity      20201    20205       +4     
==============================================
  Files            1294     1294              
  Lines           77240    77251      +11     
  Branches         1301     1301              
==============================================
+ Hits            50056    50070      +14     
+ Misses          26799    26796       -3     
  Partials          385      385

Flag	Coverage Δ	Complexity Δ
#javascript	53.85% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.97% <100%> (ø)	20205 <0> (+4)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php	87.41% <100%> (+0.02%)	209 <0> (+1)	⬆️
console.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
...ederatedfilesharing/lib/FederatedShareProvider.php	62.68% <0%> (+0.02%)	87% <0%> (+2%)	⬆️
apps/federatedfilesharing/lib/Notifications.php	41.77% <0%> (+6.05%)	45% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3860f62...e85f44f. Read the comment docs.

[codecov]

Codecov Report

Merging #35544 into stable10 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable10   #35544      +/-   ##
==============================================
+ Coverage       64.81%   64.81%   +<.01%     
- Complexity      20204    20205       +1     
==============================================
  Files            1294     1294              
  Lines           77250    77251       +1     
  Branches         1301     1301              
==============================================
+ Hits            50069    50070       +1     
  Misses          26796    26796              
  Partials          385      385

Flag	Coverage Δ	Complexity Δ
#javascript	53.85% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.97% <100%> (ø)	20205 <0> (+1)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php	87.41% <100%> (+0.02%)	209 <0> (+1)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b8a69...0c09977. Read the comment docs.

[individual-it]

changes in test code looks good 👍

[patrickjahns]

Please port on 10.2.1 release once approved/merged

[phil-davis]

PR for release-10.2.1 is #35563