Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Backport of languages from master #32557

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Sep 4, 2018

Backport of recent translations from master to stable10

@PVince81 PVince81 added this to the development milestone Sep 4, 2018
@PVince81 PVince81 self-assigned this Sep 4, 2018
@codecov
Copy link

codecov bot commented Sep 4, 2018

Codecov Report

Merging #32557 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #32557   +/-   ##
===========================================
  Coverage       62.88%   62.88%           
  Complexity      18786    18786           
===========================================
  Files            1228     1228           
  Lines           73686    73686           
  Branches         1282     1282           
===========================================
  Hits            46335    46335           
  Misses          26971    26971           
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.16% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.94% <ø> (ø) 18786 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ed920b...814331e. Read the comment docs.

@PVince81 PVince81 merged commit b5d785f into stable10 Sep 4, 2018
@PVince81 PVince81 deleted the backport/translations-stable10-master branch September 4, 2018 19:52
@phil-davis
Copy link
Contributor

I didn't review this because I did not feel "qualified" to review it. I suspect that is partly why there was no reviewer. We have 1 automated test that changes the language. But we have no automated way to "really know" that other languages work. I raised issue #32583 for discussion.

@PVince81 PVince81 modified the milestones: development, QA Sep 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants