Repair step list and execution from occ #29830

tomneedham · 2017-12-13T10:30:07Z

occ maintenance:repair --list and occ maintenance:repair --single "OC\Repair\MoveAvatarOutsideHome"

Question: Should we force enable maintenance mode?

core/Command/Maintenance/Repair.php

PVince81

Cool thing. Expecting codecov complains. Needs tests.

codecov · 2017-12-13T13:45:05Z

Codecov Report

Merging #29830 into master will increase coverage by 0.27%.
The diff coverage is 90.24%.

@@             Coverage Diff              @@
##             master   #29830      +/-   ##
============================================
+ Coverage     64.81%   65.08%   +0.27%     
- Complexity    18375    18385      +10     
============================================
  Files          1199     1199              
  Lines         69574    69610      +36     
  Branches       1282     1282              
============================================
+ Hits          45091    45304     +213     
+ Misses        24110    23933     -177     
  Partials        373      373

Flag	Coverage Δ	Complexity Δ
#javascript	`53.08% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`66.47% <90.24%> (+0.3%)`	`18385 <9> (+10)`	⬆️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Repair/MoveAvatarOutsideHome.php	`44.82% <ø> (+44.82%)`	`8 <0> (ø)`	⬇️
core/register_command.php	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
lib/private/Repair.php	`80% <100%> (+54.11%)`	`21 <1> (ø)`	⬇️
core/Command/Maintenance/Repair.php	`90.51% <94.8%> (+90.51%)`	`29 <8> (+10)`	⬆️
apps/files_trashbin/lib/Expiration.php	`96.55% <0%> (-1.73%)`	`29% <0%> (ø)`
...eratedfilesharing/lib/Controller/OcmController.php	`66.06% <0%> (-0.21%)`	`30% <0%> (ø)`
lib/private/Server.php	`86.54% <0%> (+0.23%)`	`253% <0%> (ø)`	⬇️
lib/private/Repair/RepairMismatchFileCachePath.php	`98.05% <0%> (+1.16%)`	`51% <0%> (ø)`	⬇️
lib/private/AllConfig.php	`94.52% <0%> (+1.36%)`	`43% <0%> (ø)`	⬇️
lib/private/Repair/RepairUnmergedShares.php	`30% <0%> (+1.66%)`	`41% <0%> (ø)`	⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce83d92...771474e. Read the comment docs.

core/Command/Maintenance/Repair.php

PVince81 · 2018-04-24T14:37:28Z

abandoned PR ? moving to triage for rescheduling

PVince81 · 2018-06-28T13:11:27Z

@tomneedham do you intend to finish this some day or should we take over ?

karakayasemi · 2019-02-10T15:46:21Z

the repair steps of applications added to list option (the dav app has repair steps).
only --list option run if the server is not in maintenance mode.
I refactored code a bit and added tests.

@tomneedham, @PVince81 please review. I will squash my commit after review.

karakayasemi · 2019-02-10T16:53:00Z

@ownclouders rebase

ownclouders · 2019-02-10T16:53:02Z

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

karakayasemi · 2019-02-10T16:53:40Z

unrelated UI test fail. Rebased to try one more time.

ownclouders · 2019-02-10T16:54:11Z

Automated rebase with GitMate.io was successful! 🎉

core/Command/Maintenance/Repair.php

karakayasemi · 2019-02-12T10:50:24Z

@VicDeo all issues are addressed. Please review again.

VicDeo

Let's wait for CI

VicDeo · 2019-02-14T11:23:39Z

@PVince81 backport?

PVince81 · 2019-02-14T15:30:01Z

@karakayasemi please backport

phil-davis · 2019-03-09T02:56:30Z

Backport stable10 #34499

pmaier1 · 2019-04-09T08:15:43Z

Has this been documented?

karakayasemi · 2019-04-09T14:16:16Z

I could not find any ticket for documentation. Raised in here: owncloud/docs#946

tomneedham added the 3 - To Review label Dec 13, 2017

tomneedham added this to the development milestone Dec 13, 2017

tomneedham self-assigned this Dec 13, 2017

tomneedham requested review from PVince81 and butonic December 13, 2017 10:30

PVince81 reviewed Dec 13, 2017

View reviewed changes

core/Command/Maintenance/Repair.php Show resolved Hide resolved

PVince81 reviewed Dec 13, 2017

View reviewed changes

tomneedham mentioned this pull request Dec 13, 2017

[stable10] Occ repair list and single run command #29833

Closed

ownclouders added the status/STALE label Dec 21, 2017

PVince81 modified the milestones: development, planned Jan 12, 2018

ownclouders added status/STALE and removed status/STALE labels Jan 30, 2018

tomneedham commented Feb 9, 2018

View reviewed changes

core/Command/Maintenance/Repair.php Show resolved Hide resolved

ownclouders removed the status/STALE label Feb 10, 2018

ownclouders added the status/STALE label Feb 17, 2018

felixboehm modified the milestones: development, planned Apr 10, 2018

ownclouders removed the status/STALE label Apr 24, 2018

PVince81 unassigned tomneedham Apr 24, 2018

PVince81 modified the milestones: development, triage Apr 24, 2018

ownclouders added the status/STALE label May 2, 2018

PVince81 modified the milestones: triage, maybe some day May 22, 2018

PVince81 added this to the backlog milestone Feb 8, 2019

karakayasemi force-pushed the occ-repair branch from 1c8d118 to b6a5ab3 Compare February 10, 2019 15:31

karakayasemi requested a review from PVince81 February 10, 2019 15:46

karakayasemi force-pushed the occ-repair branch from b6a5ab3 to 43cca0a Compare February 10, 2019 16:02

ownclouders force-pushed the occ-repair branch from 43cca0a to bd47e3e Compare February 10, 2019 16:54

PVince81 requested review from VicDeo and jvillafanez February 11, 2019 14:26

VicDeo reviewed Feb 11, 2019

View reviewed changes

core/Command/Maintenance/Repair.php Outdated Show resolved Hide resolved

core/Command/Maintenance/Repair.php Outdated Show resolved Hide resolved

karakayasemi force-pushed the occ-repair branch from bd47e3e to 1a7f71b Compare February 12, 2019 10:23

Add repair step list and single run from occ

771474e

karakayasemi force-pushed the occ-repair branch from 1a7f71b to 771474e Compare February 12, 2019 10:47

VicDeo approved these changes Feb 12, 2019

View reviewed changes

VicDeo merged commit e44173a into master Feb 14, 2019

delete-merged-branch bot deleted the occ-repair branch February 14, 2019 11:23

PVince81 added the backport-request label Feb 14, 2019

karakayasemi mentioned this pull request Feb 15, 2019

[stable10] Repair step list and execution from occ #34499

Merged

phil-davis removed the backport-request label Mar 9, 2019

karakayasemi mentioned this pull request Apr 9, 2019

Repair step list and single step execution from occ owncloud/docs#946

Closed

12 tasks

lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Repair step list and execution from occ #29830

Repair step list and execution from occ #29830

tomneedham commented Dec 13, 2017

PVince81 left a comment

codecov bot commented Dec 13, 2017 •

edited

Loading

PVince81 commented Apr 24, 2018

PVince81 commented Jun 28, 2018

karakayasemi commented Feb 10, 2019 •

edited

Loading

karakayasemi commented Feb 10, 2019

ownclouders commented Feb 10, 2019

karakayasemi commented Feb 10, 2019

ownclouders commented Feb 10, 2019

karakayasemi commented Feb 12, 2019

VicDeo left a comment

VicDeo commented Feb 14, 2019

PVince81 commented Feb 14, 2019

phil-davis commented Mar 9, 2019

pmaier1 commented Apr 9, 2019

karakayasemi commented Apr 9, 2019 •

edited

Loading

Repair step list and execution from occ #29830

Repair step list and execution from occ #29830

Conversation

tomneedham commented Dec 13, 2017

PVince81 left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 13, 2017 • edited Loading

Codecov Report

PVince81 commented Apr 24, 2018

PVince81 commented Jun 28, 2018

karakayasemi commented Feb 10, 2019 • edited Loading

karakayasemi commented Feb 10, 2019

ownclouders commented Feb 10, 2019

karakayasemi commented Feb 10, 2019

ownclouders commented Feb 10, 2019

karakayasemi commented Feb 12, 2019

VicDeo left a comment

Choose a reason for hiding this comment

VicDeo commented Feb 14, 2019

PVince81 commented Feb 14, 2019

phil-davis commented Mar 9, 2019

pmaier1 commented Apr 9, 2019

karakayasemi commented Apr 9, 2019 • edited Loading

codecov bot commented Dec 13, 2017 •

edited

Loading

karakayasemi commented Feb 10, 2019 •

edited

Loading

karakayasemi commented Apr 9, 2019 •

edited

Loading