Apps update in loadApps issue for concurrent requests

[PVince81]

I haven't reproduced this case yet, but it is likely to happen.

From my understanding, if the app version in the DB is less then the current code version, the next time the app is loaded it will auto-update.

The problem with this is that if there are more than one PHP request happening, it will cause the update code to run twice in parallel and is likely to mess up the DB if the app has a update.php, because there is no locking mechanism.

So, I was wondering why we had such app updates in the first place.
I understand that core apps need to update automatically during the main update routine or at the time they get enabled, in case they were disabled earlier.

One alternative would be to have a button in the app store "update all apps" to manually update apps. Normally apps would update themselves during the core upgrade but there are situations where it's not the case.

What do you think ?

@karlitschek @georgehrke @icewind1991 @DeepDiver1975

I wrote this mostly because of the recent upgrade issues from many people that were caused by concurrent loadApps/updateApps: #9824

[PVince81]

Another case popped up: when running the CLI upgrade the console.php also calls loadApps(), which triggers the upgrade too early.

[PVince81]

I wonder how this could have ever worked before... maybe because apps didn't do that many update changes in previous releases.

[PVince81]

@icewind1991's PR will prevent this: #9866

[PVince81]

Assigning to @icewind1991 for visilibilty (since the work is in the PR)

[PVince81]

Fixed in #9866