oc-1984 - File upload broken in OC-4.5 using MS IE 8 (and maybe 9)

[msrex]

From http://bugs.owncloud.org/thebuggenie/owncloud/issues/oc-1984

@arkascha also commented.

Description:
On irc, #owncloud two users mentioned problems with file uploads failing in OC-4.5 when using MS-IE browsers version 8 and 9. Other browsers are said to upload without problems. Error message visible in side the browser: "Token has expired. Please reload." I was able to reproduce the problem.

Apparently there is a problem with the CSRF protection token not being send by the browsers. Thus the validation obviously has to fail. I checked the client side, the token is present and used as expected for ajax calls, but aparently not for this file upload. I assume the difference between browser behaviour results from using different upload strategies. The code is in apps/files/js/files.js, lines 203 and following. That code is too complex for me to quickly spot the problem. I guess it makes sense if the author himself could take a look at this...

Reproduction steps:
Open the files app inside a OC-4.5 installation using a MS IE browser, version 8. Perform a file upload, you see the file being uploaded and removed again right away. The error message is shown as mentioned in the report.

This behaviour is different to when other (non MS IE) browsers are used.
#3 Comment posted by Christian Reiner Oct 12, 10:59

There also is an entry about this issue in the forums: http://forum.owncloud.org/viewtopic.php?f=4&l=4150
#6 Comment posted by Stefan G. Nov 06, 19:04

Confirmed for IE9 9.0.10 (KB2744842)

[karlitschek]

This should be fixed in the meantime. Have you tested this with the latest stable45 build?

[arkascha]

Sorry, no, I did not test again since I do not use MS IE myself.
I only reported this issue since I saw complaints in forum, irc and the maiing list and it had to do with CSRF protection tokens. However since my implementation of CSRF tokens has been replaced completely in the meantime (as far as I can see) I fail to be in position to contribute here...

Although there is one thing I would like to mention: The new implementation of the CSRF protection tokens as commmitted by AnybodyElse (Lukas Reschke) does have an issue with timeouts under certain circumstances. There is bug entry 527 about that here on github: #527

Whoever takes care of this MS IE issue should be aware that there might be two aspects mingled: the old upload problem originally reported here and a new problem that did arise when the CSRF tokens implementation was changed about 2 month ago.

[DeepDiver1975]

We had some PRs from @libasys regarding IE compatibility - THX again.
As these patches require a more recent version of jquery we agreed on to support IE from OC5 on.

[karlitschek]

@DeepDiver1975 @butonic Can you confirm that?

[DeepDiver1975]

IE8/9 support will come with OC5