Multiple Files Download -> URI too long

[tbo2k9]

This happens with owncload 5 until the latest 5.0.10

When you mark too many files (like 300) at once for download, it results in a too long URI.

With Firefox you get:
request failed: URI too long (longer than 8190)

With Internet Explorer you get an ugly owncloud error message "cloud not found" and a list of all files in the array.

owncloud.log:
[...]5982.JPG","IMG_5983): failed to open stream:File name too long at /var/www/owncloud/lib/files/storage/local.php#146","level":2,"time":1378210282}

This is possible due to the request being submitted via GET and not by POST.
If this is by design, the error should be catched (too many files, try to use a folder instead)

[Niduroki]

@DeepDiver1975 @bartv2

[bartv2]

@icewind1991 any idea why it uses GET?

[icewind1991]

GET is used because downloading files isn't done by ajax but by redirecting the browser to the download url

[DeepDiver1975]

@schiesbn if I recall you added a fix for this - right? THX

[PVince81]

There is a fix on master that fixes the "select all files" and either sends "allfiles=true" in the URL or downloads the parent folder.
This however doesn't fix the issue if the user doesn't select all files but just a subset.

In the future we should use POST when downloading multiple files.

[MorrisJobke]

@PVince81 Is this fixed?

[PVince81]

It is partially fixed.
If you select all files it will work fine, but if you individually select a lot of files (without having them all selected) then there is still a risk of the URL becoming too long.

I'd say let's keep it, maybe there's a way to do this with a POST call.

[PVince81]

@icewind1991 pointed out that GET is used because of the redirect, but it should be possible with other techniques like using a hidden form to POST to a separate window / iframe to trigger download.

[DeepDiver1975]

Let's address this in the scope of 8.2 as we plan to touch the files app with respect to operate via webdav

[simonschaufi]

related to owncloud/gallery/issues/159

[PVince81]

Using Webdav won't help with this. We still need a special endpoint (webdav or not) that accepts POST values instead of GET for the zip file download.

[DeepDiver1975]

@PVince81 DeepDiver1975/dav#5

[PVince81]

Moving to webdav for downloads in 9.0, changing milestone to 9.0.

CC @cmonteroluque

[ghost]

nod

[PVince81]

Using Webdav won't help with this. We still need a special endpoint (webdav or not) that accepts POST values instead of GET for the zip file download.

Still an issue in 9.0.

[PVince81]

I wonder if a REPORT request would be adequate for this...

[PVince81]

Requires zip endpoint to download multiple files: #17014

[PVince81]

This is not fixable without introducing new APIs/endpoints, moving to 9.2.

[PVince81]

Looks like we'd rather need a special "POST" endpoint where the list of files can be posted. This doesn't sounds very Webdav-y or REST-y.

@DeepDiver1975

Needs further research.

[hodyroff]

Can we just have a good error message or difficult/impossible?

[ownclouders]

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

[ownclouders]

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)