Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] button to force mount rescan in GUI #34010

Closed
mmattel opened this issue Jan 2, 2019 · 10 comments
Closed

[Feature Request] button to force mount rescan in GUI #34010

mmattel opened this issue Jan 2, 2019 · 10 comments

Comments

@mmattel
Copy link
Contributor

mmattel commented Jan 2, 2019

If you have an external (personal) mount, it would be great to have the possibiliy to manually force a rescan of the current mount or mount/current_folder with an additional entry in the action list below.

image

It should behave in the same way like you run the command (example):
sudo -uwww-data ./occ files:scan --path="user_x/files/external_mount_name/folder_name"

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #12530 (Feature Request), #8569 (Feature requests), #20661 (Update), #21366 (Update), and #29873 ([Feature Request] Mark mount as read only in the mount settings).

@mmattel mmattel changed the title [Feature Request] force mount update in GUI [Feature Request] button to force mount rescan in GUI Jan 3, 2019
@PVince81
Copy link
Contributor

this would need to trigger a background job for rescanning
also means not compatible with "save credentials in session" mode as the bkg job wouldn't be able to connect, so the menu item should only be visible when it makes sense

@PVince81 PVince81 added this to the backlog milestone Jan 11, 2019
@mmattel
Copy link
Contributor Author

mmattel commented Jan 11, 2019

Questions:

  • The current occ documentation about files:scan does not mention any limitation for scanning regarding „save credentials in session“. Do we need to adopt the content to reflect that?
  • In case yes, it would be good to also reflect that somehow in occ files_external:list for easy identification if a mount point has fixed or session credentials as the latter would not be scannable by occ.
  • For my better understanding, is or would there be a difference in between the occ command and a backgroundjob?

@PVince81
Copy link
Contributor

the doc in question should already be in owncloud-archive/documentation#4283

@PVince81
Copy link
Contributor

also, no difference between bkg job and cron. The point is that there is no user session active in any of these two, so whatever credentials stored in "whatever session" is not accessible.

@mmattel
Copy link
Contributor Author

mmattel commented Jan 11, 2019

Thanks, I will check and see if we add a link in the occ files:scan descriptoin to the known limitations you referenced, might be helpful.

@mmattel
Copy link
Contributor Author

mmattel commented Jan 15, 2019

Additional question:
When the user is logged in (a session based mount is used) and he clicks on such a rescan button, the session data would be available. Clould that session data be handed over to the backgroundjob and initiate scanning?

@PVince81
Copy link
Contributor

over the last years we always decided against storing such data in background jobs, which would mean storing passwords in a way that can be decrypted, which comes with security concerns

@mmattel
Copy link
Contributor Author

mmattel commented Jan 18, 2019

valid argument 👍

@stale
Copy link

stale bot commented Sep 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants