Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static tags are shown in the searchbox "Select tags to filter by" even when they do not belong to the user's group #34002

Closed
davitol opened this issue Jan 2, 2019 · 4 comments · Fixed by #34007

Comments

@davitol
Copy link
Contributor

davitol commented Jan 2, 2019

Steps to reproduce

  1. Create admin user followed by users user1, user2, user3 and user4.

  2. Create 2 groups group1 and group2. user1 and user2 belong to group1. And user3 belong to group2. user4 belongs to group1 and group2.

  3. Now create 4 tags

    • visibleTag of type Visible
    • restrictedTag of type Restricted and add group1 to it
    • staticTag of type Static and add group2 to it
    • invisibleTag of type Invisible
  4. Login to user1

Expected behaviour

The users will see restrictedTag and visibleTag.
The static tag should not be visible for users of group1

Actual behaviour

The static tag is shown in the search box

screen shot 2019-01-02 at 10 31 48

Note: The behavior is fine in the sidebar for assigning tags to a file. The static tag is not shown there.

screen shot 2019-01-02 at 10 38 47

Server configuration

Operating system:
Ubuntu 16.04

Web server:
Apache

Database:
MySQL

PHP version:
7.1

ownCloud version:

ownCloud 10.1. beta version

{"installed":true,"maintenance":false,"needsDbUpgrade":false,"version":"10.1.0.1","versionstring":"10.1.0 beta","edition":"Enterprise","productname":"ownCloud"}

Updated from an older ownCloud or fresh install:
Fresh

Are you using external storage, if yes which one:
No

Are you using encryption:
No
Logs

Client configuration

browser

Firefox

@ownclouders
Copy link
Contributor

GitMate.io thinks the contributor most likely able to help you is @PVince81.

Possibly related issues are #15818 (admin should not be able to select ldap groups for users), #9332 (Searching causes all groups to disappear even when users are present.), #11446 (User can't see all selected groups when configuring LDAP Group filter tab), #20470 (A yellow warning should be shown when creating a user/group that already exists), and #22175 (LDAP users belonging to group sometimes not showing OC 8.2.2).

@davitol
Copy link
Contributor Author

davitol commented Jan 2, 2019

cc @sharidas JFYI

@sharidas
Copy link
Contributor

sharidas commented Jan 2, 2019

It tries to get the list from request remote.php/dav/systemtags. I think it would be better to modify the result in the https://github.com/owncloud/core/blob/master/apps/systemtags/js/systemtagsfilelist.js#L132.

@sharidas
Copy link
Contributor

sharidas commented Jan 2, 2019

Created PR : #34007

  • JS unit test

@PVince81 PVince81 modified the milestones: backlog, development Feb 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants