Persistent lock timeout value is "Second-" when not specified.

[PVince81]

Steps

See steps from #33769.

Expected

<d:timeout>Infinite</d:timeout> or empty.

Actual

<d:timeout>Second-</d:timeout> or empty.

If we set the header "Timeout" to "Second-120" for example, the value appears as "Second-120" so the bug is only when no timeout is specified.

Version

master daa38db

Might be a Sabre bug, will raise there.

@DeepDiver1975 FYI

[DeepDiver1975]

Might be a Sabre bug, will raise there.

Looks like - https://github.com/sabre-io/dav/blob/09ed9f1dc417ccdca0f31dffdf9be565285cc2f0/lib/DAV/Xml/Property/LockDiscovery.php#L92

[PVince81]

Raised sabre-io/dav#1123

We might need to add a default timeout there.

I saw that the LockManager is already using some default timeout value but somehow it is not moved over to the lockInfo in the DAV layer. Should we set it there ?

[ownclouders]

GitMate.io thinks possibly related issues are #4736 (Invalid default value even if no default is specified), #31651 (Adding persistent lock types to ILockingProvider), #24737 (File Locked), #26838 (File locking), and #159 (session timeout).

[DeepDiver1975]

Upstream fix: sabre-io/dav#1125

[PVince81]

So this will need a new release of sabre

[PVince81]

might become obsoleted by the fix of #33846 if we decide to never accept infinity for the locks

[PVince81]

for now we won't accept infinite after #34100 is merged, we've set a maximum value that cannot be exceeded. This means we won't be sending the "Infinite" response, which lowers the priority for this fix here.