Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acceptance tests for more variety of user Ids #33596

Closed
2 tasks
phil-davis opened this issue Nov 20, 2018 · 7 comments · Fixed by #38364
Closed
2 tasks

Add acceptance tests for more variety of user Ids #33596

phil-davis opened this issue Nov 20, 2018 · 7 comments · Fixed by #38364

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Nov 20, 2018

Current acceptance tests user user IDs like user0, user1,... There are some tests that verify that user IDs with non-alpha-numeric characters can be created (or not created). But we do not have much verification that user IDs containing those non-alpha-numeric characters actually work correctly in a range of situations.

  • run some or all acceptance tests with "interesting" user IDs
  • run some or all acceptance tests with user IDs that look like an email address, and with the user's email address set to the same string, and to a different string

We have already "abstracted out" the "standard passwords" used in the acceptance tests - so that the passwords used by the tests can be passed in from environment variables. That allows the acceptance test suite to be run with a different set of interesting/varied passwords if desired.

We could do the same with the user IDs. Then we can easily run the acceptance test suite with user IDs like 123.Me.test_user@test-organization.org (which uses lots of the valid special characters for a user ID).

Note: the webUI message when specifying an invalid user ID says:

Error creating user: Only the following characters are allowed in a username: "a-z", "A-Z", "0-9", and "_.@-'"

That is a clue to what should be valid and tested.

Note: since core 10.4 + is also allowed in a username.

@phil-davis
Copy link
Contributor Author

Related issue that triggered me to write this acceptance test issue: #33594

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #22485 (test), #22492 (test), #31579 (test), #32347 (Add getters for private vars of acceptance test traits), and #33506 (Adding more federation acceptance tests).

@phil-davis
Copy link
Contributor Author

  • sort out if a space character should be allowed in a user ID
  • add acceptance tests to verify that a space character is allowed and works (or not)

#33594 (comment)

@PVince81 @DeepDiver1975 @patrickjahns any idea if a user ID like John Smith should be valid?

@phil-davis
Copy link
Contributor Author

Added to upcoming sprint just for the purpose of adding basic validation tests for whatever should be the allowed and disallowed user ID strings, when attempts are made to create such user IDs with each of

  • occ command
  • Provisioning API
  • webUI user management page

Sorting out how to run all acceptance tests with varying/unusual user names will need more thought/discussion and time to implement.

@phil-davis
Copy link
Contributor Author

Another issue/regression that happened with numeric UIDs and in a particular UI+API call: #37324

We need to think about how we can do this - to "optionally" run whole sets of UI and/or API tests with a variety of UIDs/Dispaly Names and other variables.

@phil-davis
Copy link
Contributor Author

phil-davis commented Jun 11, 2020

Code is merged in the PRs linked above.
PR #37506 is an example of a test run with different user names and other user attributes.

ToDo:

@phil-davis
Copy link
Contributor Author

This can be closed when #38364 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants