Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wording of "User has never logged in" #33268

Closed
phil-davis opened this issue Oct 23, 2018 · 1 comment
Closed

Wording of "User has never logged in" #33268

phil-davis opened this issue Oct 23, 2018 · 1 comment
Assignees
@phil-davis

Comments

@phil-davis
Copy link
Contributor

Steps to reproduce

  1. create a user newuser, do not login as that user
  2. php occ user:lastseen newuser

Expected behaviour

The word "yet" or the comma, or both are a bit odd.

Could be just:

User newuser has never logged in.

or

User newuser has not logged in yet.

Actual behaviour

User newuser has never logged in, yet.
@phil-davis phil-davis mentioned this issue Oct 23, 2018
Merged
10 tasks
@phil-davis phil-davis self-assigned this Oct 23, 2018
@phil-davis phil-davis changed the title Wording of "User has never loggged in" Wording of "User has never logged in" Oct 24, 2018
@phil-davis
Copy link
Contributor Author

PR merged. Text is now:

User newuser has never logged in.

@davitol davitol mentioned this issue Jan 3, 2019
Closed
39 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@phil-davis phil-davis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phil-davis