Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File lists do not properly reload when switching #27697

Closed
PVince81 opened this issue Apr 20, 2017 · 7 comments · Fixed by #27703
Closed

File lists do not properly reload when switching #27697

PVince81 opened this issue Apr 20, 2017 · 7 comments · Fixed by #27703

Comments

@PVince81
Copy link
Contributor

Steps

  1. Go to "Deleted files" to preinitialize the list
  2. Go to "All files"
  3. Delete a file
  4. Go to "Deleted files"
  5. Refresh the page

Expected

When going back to "Deleted files", that list needs to refresh with new values, so the deleted file is visible.

Actual

List not refreshed.

The same happens if you restore a file from trash after coming from "all files", then going back there doesn't make the file appear.

Versions

ownCloud 10.0.0 RC1

Not sure if regression, I have the feeling that this did work before.

There were some changes regarding reload the list by @noveens, not sure if related.

Needs research.

@PVince81
Copy link
Contributor Author

Ok, I just tried 9.1.5 and it works correctly there, so it's a regression.

A git bisect should reveal when this was broken.

@noveens do you have time to have a look ?

@PVince81
Copy link
Contributor Author

Another case, even worse result:

  1. Share a file with someone else
  2. Switch to "Shared with others"
  3. Switch to "Shared with you"
  4. Switch back to "Shared with others"

The list is not rendered any more, but the summary still says "1 file".
Likely related to this refresh issue here.

@PVince81
Copy link
Contributor Author

Regression introduced through #27282.

The problem here is that the directory doesn't actually change when switching views, but we still need a way to force a refresh there.

@PVince81
Copy link
Contributor Author

Or maybe we should destroy the list completely when switching away. So when switching back it would recreate it from scratch.

@PVince81
Copy link
Contributor Author

I found a simple way: #27703

@noveens
Copy link
Contributor

noveens commented Apr 22, 2017

Will test more regarding the issue after 4-5 days.
Currently having exams at my university.

@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants