Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split encryption master-key into its own app #27438

Closed
PVince81 opened this issue Mar 21, 2017 · 4 comments
Closed

Split encryption master-key into its own app #27438

PVince81 opened this issue Mar 21, 2017 · 4 comments

Comments

@PVince81
Copy link
Contributor

Currently the master key mode is bundled by the default encryption module app.

Since they work differently and master key enables much more functionality to work as expected, we should move its code into a separate app.

Well, extract the code because it's intertwined with the default encryption code...

@PVince81
Copy link
Contributor Author

Note: migration could be an issue here as one would need to migrate from the old app to the new one.

@PVince81
Copy link
Contributor Author

This will be more tricky than I thought: the id of the encryption module is stored within every encrypted file's header. This means that in the current OC even master key mode will store the id of "default encryption module". So once we split the master key to be its own separate module, the id will be different so the code will not recognize this any more.

We need to have either some fallback code that still somehow makes the default module contact the master key module to make it continue working, but it's ugly.

Or need a migration path that adjusts the header of ALL files at update time (or per OCC command), which is likely to run forever for big installs...

@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

@stale
Copy link

stale bot commented Sep 20, 2021

This issue has been automatically closed.

@stale stale bot closed this as completed Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants