Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/ subdirectory does not need to be writeable #27384

Closed
UnitedMarsupials-zz opened this issue Mar 14, 2017 · 10 comments
Closed

config/ subdirectory does not need to be writeable #27384

UnitedMarsupials-zz opened this issue Mar 14, 2017 · 10 comments

Comments

@UnitedMarsupials-zz
Copy link

For people, who maintain their configuration-files with tools like Puppet, making them writeable by the Internet-exposed applications is an unnecessary security risk. Under normal circumstances the config/ subdirectory of a production ownCloud installation does not need to be writeable.

And yet, as things stand, oC considers being unable to write to the directory not even a cause for warning, but a fatal error.

Please, fix. Thank you.

@ghost
Copy link

ghost commented Mar 14, 2017

@UnitedMarsupials Does the existing config.php option config_is_read_only won't do the trick here?

https://doc.owncloud.org/server/latest/admin_manual/configuration_server/config_sample_php_parameters.html#owncloud-verifications

@UnitedMarsupials-zz
Copy link
Author

UnitedMarsupials-zz commented Mar 14, 2017

Does the existing config.php option config_is_read_only won't do the trick here?

Well, yes and no. Yes, because it does allow a work-around. No, because the stern message about it being mandatory for config to be writeable does not mention the option.

More importantly, why make it mandatory at all? If/when an admin attempts to modify the config, the error resulting from a failed attempt can be displayed. But there is no reason to disable the entire instance because of it -- regardless of the config_is_read_only setting.

@PVince81
Copy link
Contributor

Slightly related: #11843

@PVince81
Copy link
Contributor

and possible bug with read only config: #23245

@VicDeo
Copy link
Member

VicDeo commented Mar 27, 2017

right now config.php contains OC version.
I guess upgrade will be possible if there is no write access to config.php

@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.

@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@UnitedMarsupials-zz
Copy link
Author

This is still as much a bug as it was 11 months ago. But I don’t have an option to reopen. If you do, please, use it.

@PVince81 PVince81 reopened this Mar 9, 2018
@PVince81 PVince81 added this to the backlog milestone Mar 9, 2018
@PVince81
Copy link
Contributor

closing in favor of #11843 where config.php keys would be moved to the database so config.php would always be read-only

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants